Skip to content

Conversation

hanahmily
Copy link
Contributor

Fix the issue by implementing deduplication logic in priority queues
and improving sliding window memory management.

related to apache/skywalking#13501

Fix the issue by implementing deduplication logic in priority queues
 and improving sliding window memory management.

Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
@hanahmily hanahmily requested a review from mrproliu September 21, 2025 00:30
@hanahmily hanahmily added this to the 0.9.0 milestone Sep 21, 2025
@hanahmily hanahmily added the bug Something isn't working label Sep 21, 2025
@hanahmily
Copy link
Contributor Author

@mrproliu, could you redeploy the BanyanDB with this change to verify if the OOM issue persists?

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2025

Codecov Report

❌ Patch coverage is 74.41860% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.40%. Comparing base (a34e461) to head (f078433).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
banyand/measure/write_liaison.go 0.00% 6 Missing ⚠️
banyand/stream/write_liaison.go 0.00% 6 Missing ⚠️
pkg/flow/streaming/sliding_window.go 83.78% 3 Missing and 3 partials ⚠️
banyand/queue/pub/pub.go 57.14% 2 Missing and 1 partial ⚠️
pkg/flow/dedup_priority_queue.go 96.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #777       +/-   ##
===========================================
+ Coverage   38.17%   49.40%   +11.22%     
===========================================
  Files         300      304        +4     
  Lines       49741    49880      +139     
===========================================
+ Hits        18991    24643     +5652     
+ Misses      29319    23279     -6040     
- Partials     1431     1958      +527     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wu-sheng wu-sheng merged commit 04e17d0 into main Sep 21, 2025
14 checks passed
@wu-sheng wu-sheng deleted the bug/oom branch September 21, 2025 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants