fix(playwright): fix EditDatasetModal Tabs compatibility + getTab docs

EditDatasetModal passed getByRole('tablist') to Tabs, but the nav
getter expects the .ant-tabs wrapper — clicking tabs would silently
fail. Changed to pass .ant-tabs locator scoped to the dialog.

Also documented getTab substring matching behavior and strict mode
safety net for ambiguous names.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: sadpandajoe

superset-frontend/playwright/components/core/Tabs.ts

@@ -69,6 +69,10 @@ export class Tabs {
 
   /**
    * Gets a tab button by name, scoped to this component's nav bar.
+   * Uses substring matching (hasText) because tab button text includes
+   * icon text (e.g. "Untitled Query 1 circle-solid"). Pass specific
+   * enough text to avoid ambiguity — Playwright strict mode will catch
+   * collisions (e.g. "Query 1" matching "Query 10").
    * @param tabName - The name/label of the tab
    */
   getTab(tabName: string): Locator {

superset-frontend/playwright/components/modals/EditDatasetModal.ts

@@ -40,8 +40,11 @@ export class EditDatasetModal extends Modal {
     // Use getByRole with specific name to target Edit Dataset dialog
     // The dialog has aria-labelledby that resolves to "edit Edit Dataset"
     this.specificLocator = page.getByRole('dialog', { name: /edit.*dataset/i });
-    // Scope tabs to modal's tablist to avoid matching tablists elsewhere on page
-    this.tabs = new Tabs(page, this.specificLocator.getByRole('tablist'));
+    // Scope tabs to modal dialog so nav getter finds .ant-tabs-nav as descendant
+    this.tabs = new Tabs(
+      page,
+      this.specificLocator.locator('.ant-tabs').first(),
+    );
   }
 
   /**