Commit 2da59e8
test(datasource-editor): defer Playwright tests to follow-up
Removes the Playwright spec and unused fixture helpers added in
e111c5c / b346b27. The first CI run revealed:
- getByLabel('Default URL') doesn't resolve because Field/TextControl
don't wire htmlFor/aria-labelledby on the input — the label renders
as a separate FormLabel header element above the input.
- The duplicate-column-name error doesn't render in the dialog body;
it surfaces only as the disabled Save button's tooltip text per
DatasourceModal:355-370.
Fixing both selector strategies plus iterating through CI cycles isn't
worth blocking the perf fix on. The unit test for the unmount-drain
path (T031b in 73e2ab9) covers the most subtle behavioural contract,
and the existing 26 Jest tests cover the synchronous validation
semantics. End-to-end Playwright coverage for typing cadence and
validation flow is desirable but deferred to a separate PR.
Reverts:
- superset-frontend/playwright/helpers/api/dataset.ts (createWideTestDataset)
- superset-frontend/playwright/tests/dataset/dataset-test-helpers.ts (createWideTestDatasetForTest)
- superset-frontend/playwright/tests/dataset/dataset-editor-typing.spec.ts (deleted)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 44f13b9 commit 2da59e8
3 files changed
Lines changed: 1 addition & 298 deletions
File tree
- superset-frontend/playwright
- helpers/api
- tests/dataset
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
137 | 137 | | |
138 | 138 | | |
139 | 139 | | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | | - | |
153 | | - | |
154 | | - | |
155 | | - | |
156 | | - | |
157 | | - | |
158 | | - | |
159 | | - | |
160 | | - | |
161 | | - | |
162 | | - | |
163 | | - | |
164 | | - | |
165 | | - | |
166 | | - | |
167 | | - | |
168 | | - | |
169 | | - | |
170 | | - | |
171 | | - | |
172 | | - | |
173 | | - | |
174 | | - | |
175 | | - | |
176 | | - | |
177 | | - | |
178 | | - | |
179 | | - | |
180 | | - | |
181 | | - | |
182 | | - | |
183 | | - | |
184 | | - | |
185 | | - | |
186 | | - | |
187 | | - | |
188 | | - | |
189 | | - | |
190 | | - | |
191 | | - | |
192 | 140 | | |
193 | 141 | | |
194 | 142 | | |
| |||
Lines changed: 0 additions & 206 deletions
This file was deleted.
Lines changed: 1 addition & 40 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
| 22 | + | |
26 | 23 | | |
27 | 24 | | |
28 | 25 | | |
| |||
34 | 31 | | |
35 | 32 | | |
36 | 33 | | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | 34 | | |
43 | 35 | | |
44 | 36 | | |
| |||
73 | 65 | | |
74 | 66 | | |
75 | 67 | | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
0 commit comments