Skip to content

Commit ccfc07d

Browse files
hainenbersadpandajoe
authored andcommitted
fix(fe/dashboard-list): display modifier info for Last modified data (#32035)
Signed-off-by: hainenber <dotronghai96@gmail.com> (cherry picked from commit 88cf2d5)
1 parent e4d1735 commit ccfc07d

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

superset-frontend/src/pages/DashboardList/DashboardList.test.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ describe('DashboardList', () => {
161161
const callsD = fetchMock.calls(/dashboard\/\?q/);
162162
expect(callsD).toHaveLength(1);
163163
expect(callsD[0][0]).toMatchInlineSnapshot(
164-
`"http://localhost/api/v1/dashboard/?q=(order_column:changed_on_delta_humanized,order_direction:desc,page:0,page_size:25,select_columns:!(id,dashboard_title,published,url,slug,changed_by,changed_on_delta_humanized,owners.id,owners.first_name,owners.last_name,owners,tags.id,tags.name,tags.type,status,certified_by,certification_details,changed_on))"`,
164+
`"http://localhost/api/v1/dashboard/?q=(order_column:changed_on_delta_humanized,order_direction:desc,page:0,page_size:25,select_columns:!(id,dashboard_title,published,url,slug,changed_by,changed_by.id,changed_by.first_name,changed_by.last_name,changed_on_delta_humanized,owners,owners.id,owners.first_name,owners.last_name,tags.id,tags.name,tags.type,status,certified_by,certification_details,changed_on))"`,
165165
);
166166
});
167167

superset-frontend/src/pages/DashboardList/index.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,11 +118,14 @@ const DASHBOARD_COLUMNS_TO_FETCH = [
118118
'url',
119119
'slug',
120120
'changed_by',
121+
'changed_by.id',
122+
'changed_by.first_name',
123+
'changed_by.last_name',
121124
'changed_on_delta_humanized',
125+
'owners',
122126
'owners.id',
123127
'owners.first_name',
124128
'owners.last_name',
125-
'owners',
126129
'tags.id',
127130
'tags.name',
128131
'tags.type',

0 commit comments

Comments
 (0)