fix: Downgrade to marshmallow<4 #33216
Conversation
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
rusackas
added
the
review:checkpoint
michael-s-molina
removed
the
review:checkpoint
| @@ -64,6 +64,7 @@ dependencies = [ | |||
| "jsonpath-ng>=1.6.1, <2", | |||
| "Mako>=1.2.2", | |||
| "markdown>=3.0", | |||
| "marshmallow<4", | |||
There was a problem hiding this comment.
Let's always put a comment above when setting an upper bound that's not based on pure semver assumptions, something like "marshmallow>=4 has shown issues related to 'minLength'", ...
There was a problem hiding this comment.
Thank you. I didn't see such comments on other spots, but I've just added it, effectively linking to the corresponding issue on GitHub.
amotl
force-pushed
the
fix-marshmallow-4.1
branch
from
7150804 to
ba6e084
Compare
amotl
requested review from
villebro,
rusackas,
geido,
eschutho,
betodealmeida,
nytai,
craig-rueda,
john-bodley,
kgabryje,
dpgaspar,
jinghua-qa,
michael-s-molina and
a team
as code owners
github-actions
bot
added
i18n
amotl
force-pushed
the
fix-marshmallow-4.1
branch
from
ba6e084 to
2ba9729
Compare
github-actions
bot
removed
i18n
There was a problem hiding this comment.
LGTM - curious about your internal release process that lead to that issue, do you run your own uv pip compile --upgrade process internally? Or maybe you have your own snyk/dependabot-type setup in place and upgrade certain things?
In any case, would be great to centralize the dependency management and upgrades in the main repo as much as possible. Could certainly use help with the process if you wanted to get involved in dep management.
|
@mistercrunch: Thanks for merging. You can inspect the testing rig which flagged this regression through its nightly CI runs over here. HTH, otherwise feel free to ask. |
Problem
With Marshmallow 4, just released, Superset 4 trips like:
Solution
Pin dependency to
marshmallow<4.References
marshmallow>=4.0.0#33162