fix: Fixed numeric filtering issue in Superset#33222
Open
Sayan199 wants to merge 1 commit intoapache:masterfrom
Open
fix: Fixed numeric filtering issue in Superset#33222Sayan199 wants to merge 1 commit intoapache:masterfrom
Sayan199 wants to merge 1 commit intoapache:masterfrom
Conversation
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
| Missing temporal range value handling explanation ▹ view | 🧠 Not in standard |
Files scanned
| File Path | Reviewed |
|---|---|
| superset/models/helpers.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
Comment on lines
1162
to
1164
| def handle_single_value(value: Optional[FilterValue]) -> Optional[FilterValue]: | ||
| if operator == utils.FilterOperator.TEMPORAL_RANGE: | ||
| return value |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Member
|
Looks like there are a bunch of CI tasks failing, but we should probably start by running Superset uses Git pre-commit hooks courtesy of pre-commit. To install run the following: Alternatively it is possible to run pre-commit by running pre-commit manually: |
10 tasks
Member
|
Possible duplicate of #33230 |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #33206
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
In order to test this, we need to
This should now be able to filter and give results that do match with 21 but also with 21.8 and 25.35
ADDITIONAL INFORMATION