Skip to content

feat: Add currencies controls in country map#39016

Merged
SBIN2010 merged 69 commits intoapache:masterfrom
SBIN2010:feature/add_contry_map_currency_format
Apr 6, 2026
Merged

feat: Add currencies controls in country map#39016
SBIN2010 merged 69 commits intoapache:masterfrom
SBIN2010:feature/add_contry_map_currency_format

Conversation

@SBIN2010
Copy link
Copy Markdown
Contributor

@SBIN2010 SBIN2010 commented Apr 1, 2026

This PR adds currency controls to the country map.
In PR #24718, exchange controls were added to the world map but were not added to the country map.

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Снимок экрана от 2026-04-02 00-26-41

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

SBIN2010 and others added 30 commits October 22, 2024 23:07
@github-actions github-actions bot added 🎪 5cc3b9e 📅 2026-04-03T21-04 Environment 5cc3b9e created at 2026-04-03T21-04 🎪 5cc3b9e 🤡 SBIN2010 Environment 5cc3b9e requested by SBIN2010 labels Apr 3, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

🎪 Showtime is building environment on GHA for 5cc3b9e

@github-actions github-actions bot added 🎪 5cc3b9e 🚦 deploying Environment 5cc3b9e status: deploying and removed 🎪 5cc3b9e 🚦 building Environment 5cc3b9e status: building labels Apr 3, 2026
@SBIN2010 SBIN2010 removed 🎪 ⌛ 48h Environment expires after 48 hours (default) 🎪 5cc3b9e 🤡 SBIN2010 Environment 5cc3b9e requested by SBIN2010 🎪 5cc3b9e 🚦 deploying Environment 5cc3b9e status: deploying 🎪 5cc3b9e 📅 2026-04-03T21-04 Environment 5cc3b9e created at 2026-04-03T21-04 labels Apr 3, 2026
@github-actions github-actions bot added 🎪 5cc3b9e 🚦 running Environment 5cc3b9e status: running 🎪 🎯 5cc3b9e Active environment pointer - 5cc3b9e is receiving traffic 🎪 5cc3b9e 📅 2026-04-03T21-04 Environment 5cc3b9e created at 2026-04-03T21-04 🎪 5cc3b9e 🌐 54.188.144.251:8080 Environment 5cc3b9e URL: http://54.188.144.251:8080 (click to visit) 🎪 5cc3b9e 🤡 SBIN2010 Environment 5cc3b9e requested by SBIN2010 and removed 🎪 5cc3b9e 🚦 running Environment 5cc3b9e status: running 🎪 🎯 5cc3b9e Active environment pointer - 5cc3b9e is receiving traffic labels Apr 3, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

🎪 Showtime deployed environment on GHA for 5cc3b9e

Environment: http://54.188.144.251:8080 (admin/admin)
Lifetime: 48h auto-cleanup
Updates: New commits create fresh environments automatically

@github-actions github-actions bot removed 🎪 5cc3b9e 🤡 SBIN2010 Environment 5cc3b9e requested by SBIN2010 🎪 5cc3b9e 📅 2026-04-03T21-04 Environment 5cc3b9e created at 2026-04-03T21-04 🎪 5cc3b9e 🌐 54.188.144.251:8080 Environment 5cc3b9e URL: http://54.188.144.251:8080 (click to visit) 🎪 5cc3b9e 🚦 running Environment 5cc3b9e status: running labels Apr 6, 2026
@bito-code-review
Copy link
Copy Markdown
Contributor

bito-code-review bot commented Apr 6, 2026

Code Review Agent Run #aa60e4

Actionable Suggestions - 0
Review Details
  • Files reviewed - 2 · Commit Range: 5cc3b9e..5813105
    • superset-frontend/plugins/legacy-plugin-chart-country-map/src/CountryMap.ts
    • superset-frontend/plugins/legacy-plugin-chart-country-map/src/transformProps.ts
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • Eslint (Linter) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@rusackas
Copy link
Copy Markdown
Member

rusackas commented Apr 6, 2026

One nit: formatter is typed as optional in CountryMapProps, but it's used unconditionally in the tooltip (formatter(result[0].metric)). Since transformProps always provides it, I'd just make it required in the interface. Otherwise a future caller could omit it and hit a runtime error.

Other than that, LGTM 👍

Copy link
Copy Markdown
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but you might want to look at trying up that one loose end before merging.

@SBIN2010 SBIN2010 merged commit b05764d into apache:master Apr 6, 2026
84 of 86 checks passed
@bito-code-review
Copy link
Copy Markdown
Contributor

Bito Automatic Review Skipped – PR Already Merged

Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.
No action is needed if you didn't intend to review it. To get a review, you can type /review in a comment and save it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants