Cleanup - some more clang-tidy recommendation. (#12172)

* Cleanup - some more clang-tidy recommendation.

Author: brbzull0

src/iocore/net/P_UnixNet.h

@@ -198,8 +198,9 @@ check_transient_accept_error(int res)
     last_transient_accept_error = t;
     Warning("accept thread received transient error: errno = %d", -res);
 #if defined(__linux__)
-    if (res == -ENOBUFS || res == -ENFILE)
+    if (res == -ENOBUFS || res == -ENFILE) {
       Warning("errno : %d consider a memory upgrade", -res);
+    }
 #endif
   }
 }

src/iocore/net/SSLUtils.cc

@@ -1015,7 +1015,7 @@ asn1_strdup(ASN1_STRING *s)
   ink_assert(ASN1_STRING_type(s) == V_ASN1_IA5STRING || ASN1_STRING_type(s) == V_ASN1_UTF8STRING ||
              ASN1_STRING_type(s) == V_ASN1_PRINTABLESTRING || ASN1_STRING_type(s) == V_ASN1_T61STRING);
 
-  return ats_strndup((const char *)ASN1_STRING_get0_data(s), ASN1_STRING_length(s));
+  return ats_strndup(reinterpret_cast<const char *>(ASN1_STRING_get0_data(s)), ASN1_STRING_length(s));
 }
 
 // This callback function is executed while OpenSSL processes the SSL

src/proxy/http/remap/unit-tests/test_PluginDso.cc

@@ -68,20 +68,20 @@ class PluginDsoUnitTest : public PluginDso
   {
   }
 
-  virtual void
+  void
   indicatePreReload() override
   {
   }
-  virtual void
+  void
   indicatePostReload(TSRemapReloadStatus /* reloadStatus ATS_UNUSED */) override
   {
   }
-  virtual bool
+  bool
   init(std::string & /* error ATS_UNUSED */) override
   {
     return true;
   }
-  virtual void
+  void
   done() override
   {
   }

src/traffic_server/traffic_server.cc

@@ -595,7 +595,7 @@ init_memory_tracker(const char *config_var, RecDataT /* type ATS_UNUSED */, RecD
 void
 proxy_signal_handler(int signo, siginfo_t *info, void *ctx)
 {
-  if ((unsigned)signo < countof(signal_received)) {
+  if (static_cast<unsigned>(signo) < countof(signal_received)) {
     signal_received[signo] = true;
   }