Skip to content

Run autests with curl UDS default #12168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

serrislew
Copy link
Contributor

@serrislew serrislew commented Apr 7, 2025

Extension of #12122

Add autest-uds cmake preset to run all autests with curl --unix-socket [ts_runtime_dir/socket] command

  • skips h2 and tls autests for uds case
  • skips unrelated autests or specific test runs with Condition.CurlIsUsingUnixDomainSocket()
    • changes include removing --ipv4 flag when --unix-socket is present, not including full url in gold file, etc
  • curl_base string format created to just have curl (without uds flag) available in uds case

Resolves #12184

@serrislew serrislew added this to the 10.2.0 milestone Apr 7, 2025
@serrislew serrislew self-assigned this Apr 7, 2025
@bneradt bneradt self-requested a review April 7, 2025 22:06
@serrislew serrislew marked this pull request as draft April 12, 2025 00:58
Copy link
Contributor

@bneradt bneradt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this and giving an example of adding uds testing to a test in the bigobj.test.py file.

Posting a quick observation while we continue to discuss how to move forward.

@serrislew serrislew marked this pull request as ready for review April 29, 2025 04:45
@serrislew
Copy link
Contributor Author

[approve ci]

@serrislew serrislew requested a review from bneradt April 30, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Domain socket path for autest should be in the trafficserver runtime directory, not the test directory
2 participants