Skip to content

Updated SSLSNIConfig to use the Regex class (pcre2) #12219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bryancall
Copy link
Contributor

No description provided.

@bryancall bryancall added this to the 10.2.0 milestone May 2, 2025
@bryancall bryancall self-assigned this May 2, 2025
@bryancall bryancall requested a review from Copilot May 2, 2025 17:03
Copilot

This comment was marked as outdated.

@bryancall bryancall requested a review from Copilot May 2, 2025 19:30
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the regex functionality in SSLSNIConfig to use the new Regex class based on PCRE2 instead of legacy PCRE usage. It introduces a move assignment operator and an empty() helper in the Regex class, updates regex compilation and execution in SSLSNIConfig, and removes obsolete PCRE includes.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/tsutil/Regex.cc Added move assignment operator and empty() method; adjusted exec() behavior to update match vector size.
include/tsutil/Regex.h Added declaration for move assignment operator and empty() method.
src/iocore/net/SSLSNIConfig.cc Replaced PCRE API calls with Regex class methods and updated capture groups handling.
include/iocore/net/SSLSNIConfig.h Removed PCRE header inclusion and updated NamedElement's regex member to use Regex.

@bryancall bryancall marked this pull request as draft May 5, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant