Wasm plugin: Handle AF_INET6 case for port extraction #12635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wasm plugin: Handle AF_INET6 case for port extraction
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds an explicit IPv6 family check in the print_port function to make the address family handling more explicit and safer.
- Changes the
elseclause toelse if (ip->sa_family == AF_INET6)in theprint_portfunction
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Add debug logging for unsupported address families.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
randall
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes a small but important fix to the
print_portfunction inplugins/experimental/wasm/ats_context.cc. The change improves how the function determines the IP address family before extracting the port number.AF_INET6instead of using a genericelse, ensuring correct behavior when the address family is not IPv4 or IPv6.Wasm plugin: Handle AF_INET6 case for port extraction