Skip to content

Ensure ServerSockets are closed in ensureComplete #2263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −6
Open

Ensure ServerSockets are closed in ensureComplete #2263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions ...r-server/src/main/java/org/apache/zookeeper/server/controller/ControllerServerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,14 +134,17 @@ public void ensureComplete() throws IOException {
// We will use majority strategy with only this host in the quorum.
// We need to provide 2 more ports: one for elections and one for quorum communications.
// We will also mark this host as the leader.
ServerSocket randomSocket1 = new ServerSocket(0);
int quorumPort = randomSocket1.getLocalPort();
int quorumPort;
int electionPort;

ServerSocket randomSocket2 = new ServerSocket(0);
int electionPort = randomSocket2.getLocalPort();
// Use try-with-resources to find available ports and ensure sockets are closed
try (ServerSocket randomSocket1 = new ServerSocket(0);
ServerSocket randomSocket2 = new ServerSocket(0)) {

randomSocket1.close();
randomSocket2.close();
quorumPort = randomSocket1.getLocalPort();
electionPort = randomSocket2.getLocalPort();

}

QuorumPeer.QuorumServer selfAsPeer = new QuorumPeer.QuorumServer(
0,
Expand Down