ZOOKEEPER-4958: Fix client hostname verification ignored in server if ssl.authProvider configured #2303
+486
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezhuw
force-pushed
the
ZOOKEEPER-4958-client-server-hostname-verification
branch
from
65e0089 to
c2a44bf
Compare
Since, `ZooKeeperServerEmbedded` could bind to port 0 and get unused port from system. It would be good to export the bound client port in addition to `getConnectionString`.
… ssl.authProvider configured `NettyServerCnxnFactory` uses `TrustManager` from `X509AuthenticationProvider` if `ssl.authProvider` is configured. But `clientHostnameVerificationEnabled` is explicitly set to `false` in construction of `X509AuthenticationProvider`. This cause the server skip hostname verification agaist client certificate. This is reproducible in case of following server configs: * zookeeper.ssl.hostnameVerification: true * zookeeper.ssl.clientHostnameVerification: true * zookeeper.fips-mode: false * zookeeper.ssl.authProvider: x509
kezhuw
force-pushed
the
ZOOKEEPER-4958-client-server-hostname-verification
branch
from
c2a44bf to
6f53980
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NettyServerCnxnFactoryusesTrustManagerfromX509AuthenticationProviderif
ssl.authProvideris configured. ButclientHostnameVerificationEnabledis explicitly set to
falsein construction ofX509AuthenticationProvider.This cause the server skip hostname verification agaist client
certificate.
This is reproducible in case of following server configs: