chore: fix CI (#6144)

* chore: disable keep_legacy_inflector in Doctrine tests

* chore: fix Doctrine ORM enable_lazy_ghost_objects deprecation in tests configuration

* chore: fix null value for CS

* chore: fix CS post rebase from main

* chore: remove useless legacy test services

* chore: fix YAML with Symfony dev dependencies

Author: vincentchalamon

components.php

@@ -86,7 +86,7 @@
 }
 
 $warned = [];
-$getComponentNamespace = function (ReflectionClass $r, ReflectionClass $inside = null) use ($psrMap, $warned, $ignoreList, $namespace) {
+$getComponentNamespace = function (ReflectionClass $r, ?ReflectionClass $inside = null) use ($psrMap, $warned, $ignoreList, $namespace) {
     $ns = $r->getNamespaceName();
     // Find this components namespace
     $nsParts = explode('\\', $ns);

src/Doctrine/Common/State/LinksHandlerTrait.php

@@ -92,7 +92,7 @@ private function getLinks(string $resourceClass, Operation $operation, array $co
     /**
      * @param array<int|string,mixed> $identifiers
      */
-    private function getIdentifierValue(array &$identifiers, string $name = null): mixed
+    private function getIdentifierValue(array &$identifiers, ?string $name = null): mixed
     {
         if (null !== $name && isset($identifiers[$name])) {
             $value = $identifiers[$name];
@@ -107,7 +107,7 @@ private function getIdentifierValue(array &$identifiers, string $name = null): m
     /**
      * @return \ApiPlatform\Metadata\Link[]|array
      */
-    private function getOperationLinks(Operation $operation = null): array
+    private function getOperationLinks(?Operation $operation = null): array
     {
         if ($operation instanceof GraphQlOperation) {
             return $operation->getLinks() ?? [];

src/Doctrine/Odm/State/CollectionProvider.php

@@ -36,7 +36,7 @@ final class CollectionProvider implements ProviderInterface
     /**
      * @param AggregationCollectionExtensionInterface[] $collectionExtensions
      */
-    public function __construct(ResourceMetadataCollectionFactoryInterface $resourceMetadataCollectionFactory, ManagerRegistry $managerRegistry, private readonly iterable $collectionExtensions = [], ContainerInterface $handleLinksLocator = null)
+    public function __construct(ResourceMetadataCollectionFactoryInterface $resourceMetadataCollectionFactory, ManagerRegistry $managerRegistry, private readonly iterable $collectionExtensions = [], ?ContainerInterface $handleLinksLocator = null)
     {
         $this->resourceMetadataCollectionFactory = $resourceMetadataCollectionFactory;
         $this->handleLinksLocator = $handleLinksLocator;

src/Doctrine/Odm/State/ItemProvider.php

@@ -39,7 +39,7 @@ final class ItemProvider implements ProviderInterface
     /**
      * @param AggregationItemExtensionInterface[] $itemExtensions
      */
-    public function __construct(ResourceMetadataCollectionFactoryInterface $resourceMetadataCollectionFactory, ManagerRegistry $managerRegistry, private readonly iterable $itemExtensions = [], ContainerInterface $handleLinksLocator = null)
+    public function __construct(ResourceMetadataCollectionFactoryInterface $resourceMetadataCollectionFactory, ManagerRegistry $managerRegistry, private readonly iterable $itemExtensions = [], ?ContainerInterface $handleLinksLocator = null)
     {
         $this->resourceMetadataCollectionFactory = $resourceMetadataCollectionFactory;
         $this->handleLinksLocator = $handleLinksLocator;

src/Doctrine/Odm/State/LinksHandlerTrait.php

@@ -31,7 +31,7 @@ trait LinksHandlerTrait
 
     private ManagerRegistry $managerRegistry;
 
-    private function handleLinks(Builder $aggregationBuilder, array $identifiers, array $context, string $resourceClass, Operation $operation = null): void
+    private function handleLinks(Builder $aggregationBuilder, array $identifiers, array $context, string $resourceClass, ?Operation $operation = null): void
     {
         if (!$identifiers) {
             return;

src/Doctrine/Odm/Tests/Fixtures/Document/Dummy.php

@@ -152,12 +152,12 @@ public function getFoo(): ?array
         return $this->foo;
     }
 
-    public function setFoo(array $foo = null): void
+    public function setFoo(?array $foo = null): void
     {
         $this->foo = $foo;
     }
 
-    public function setDummyDate(\DateTime $dummyDate = null): void
+    public function setDummyDate(?\DateTime $dummyDate = null): void
     {
         $this->dummyDate = $dummyDate;
     }

src/Doctrine/Odm/Tests/Fixtures/Document/RelatedDummy.php

@@ -113,7 +113,7 @@ public function getThirdLevel(): ?ThirdLevel
         return $this->thirdLevel;
     }
 
-    public function setThirdLevel(ThirdLevel $thirdLevel = null): void
+    public function setThirdLevel(?ThirdLevel $thirdLevel = null): void
     {
         $this->thirdLevel = $thirdLevel;
     }

src/Doctrine/Odm/Tests/Fixtures/Document/ThirdLevel.php

@@ -77,7 +77,7 @@ public function getFourthLevel(): ?FourthLevel
         return $this->fourthLevel;
     }
 
-    public function setFourthLevel(FourthLevel $fourthLevel = null): void
+    public function setFourthLevel(?FourthLevel $fourthLevel = null): void
     {
         $this->fourthLevel = $fourthLevel;
     }

src/Doctrine/Odm/Tests/config.yml

@@ -21,6 +21,7 @@ api_platform:
         json: ['application/json']
     doctrine: false
     doctrine_mongodb_odm: true
+    keep_legacy_inflector: false
     mapping:
         paths:
             - '%kernel.project_dir%/Fixtures/Document'

src/Doctrine/Orm/State/CollectionProvider.php

@@ -39,7 +39,7 @@ final class CollectionProvider implements ProviderInterface
     /**
      * @param QueryCollectionExtensionInterface[] $collectionExtensions
      */
-    public function __construct(ResourceMetadataCollectionFactoryInterface $resourceMetadataCollectionFactory, ManagerRegistry $managerRegistry, private readonly iterable $collectionExtensions = [], ContainerInterface $handleLinksLocator = null)
+    public function __construct(ResourceMetadataCollectionFactoryInterface $resourceMetadataCollectionFactory, ManagerRegistry $managerRegistry, private readonly iterable $collectionExtensions = [], ?ContainerInterface $handleLinksLocator = null)
     {
         $this->resourceMetadataCollectionFactory = $resourceMetadataCollectionFactory;
         $this->handleLinksLocator = $handleLinksLocator;