-
-
Notifications
You must be signed in to change notification settings - Fork 909
feat: BackedEnum resources #6309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
9ec7070
2bab9b0
176a746
743069b
af8e31c
759b77e
f5e7ad2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the API Platform project. | ||
* | ||
* (c) Kévin Dunglas <dunglas@gmail.com> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
declare(strict_types=1); | ||
|
||
namespace ApiPlatform\Metadata\Resource\Factory; | ||
|
||
use ApiPlatform\Metadata\Operations; | ||
use ApiPlatform\Metadata\Resource\ResourceMetadataCollection; | ||
|
||
/** | ||
* Triggers resource deprecations. | ||
* | ||
* @internal | ||
*/ | ||
final class BackedEnumResourceMetadataCollectionFactory implements ResourceMetadataCollectionFactoryInterface | ||
{ | ||
public const PROVIDER = 'api_platform.state_provider.backed_enum'; | ||
|
||
public function __construct(private readonly ResourceMetadataCollectionFactoryInterface $decorated) | ||
{ | ||
} | ||
|
||
public function create(string $resourceClass): ResourceMetadataCollection | ||
{ | ||
$resourceMetadataCollection = $this->decorated->create($resourceClass); | ||
if (!is_a($resourceClass, \BackedEnum::class, true)) { | ||
return $resourceMetadataCollection; | ||
} | ||
|
||
foreach ($resourceMetadataCollection as $i => $resourceMetadata) { | ||
$newOperations = []; | ||
foreach ($resourceMetadata->getOperations() as $operationName => $operation) { | ||
$newOperations[$operationName] = $operation; | ||
|
||
if (null !== $operation->getProvider()) { | ||
continue; | ||
} | ||
|
||
$newOperations[$operationName] = $operation->withProvider(self::PROVIDER); | ||
} | ||
|
||
$newGraphQlOperations = []; | ||
foreach ($resourceMetadata->getGraphQlOperations() as $operationName => $operation) { | ||
$newGraphQlOperations[$operationName] = $operation; | ||
|
||
if (null !== $operation->getProvider()) { | ||
continue; | ||
} | ||
|
||
$newGraphQlOperations[$operationName] = $operation->withProvider(self::PROVIDER); | ||
} | ||
|
||
$resourceMetadataCollection[$i] = $resourceMetadata->withOperations(new Operations($newOperations))->withGraphQlOperations($newGraphQlOperations); | ||
} | ||
|
||
return $resourceMetadataCollection; | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the API Platform project. | ||
* | ||
* (c) Kévin Dunglas <dunglas@gmail.com> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
declare(strict_types=1); | ||
|
||
namespace ApiPlatform\State\Provider; | ||
|
||
use ApiPlatform\Metadata\CollectionOperationInterface; | ||
use ApiPlatform\Metadata\Exception\RuntimeException; | ||
use ApiPlatform\Metadata\Operation; | ||
use ApiPlatform\State\ProviderInterface; | ||
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException; | ||
|
||
final class BackedEnumProvider implements ProviderInterface | ||
{ | ||
public function provide(Operation $operation, array $uriVariables = [], array $context = []): object|array|null | ||
{ | ||
$resourceClass = $operation->getClass(); | ||
if (!$resourceClass || !is_a($resourceClass, \BackedEnum::class, true)) { | ||
throw new RuntimeException('This resource is not an enum'); | ||
} | ||
|
||
if ($operation instanceof CollectionOperationInterface) { | ||
return $resourceClass::cases(); | ||
} | ||
|
||
$id = $uriVariables['id'] ?? null; | ||
if (null === $id) { | ||
throw new NotFoundHttpException('Not Found'); | ||
} | ||
|
||
if ($enum = $this->resolveEnum($resourceClass, $id)) { | ||
return $enum; | ||
} | ||
|
||
throw new NotFoundHttpException('Not Found'); | ||
} | ||
|
||
/** | ||
* @param class-string $resourceClass | ||
*/ | ||
private function resolveEnum(string $resourceClass, string|int $id): ?\BackedEnum | ||
{ | ||
$reflectEnum = new \ReflectionEnum($resourceClass); | ||
$type = (string) $reflectEnum->getBackingType(); | ||
|
||
if ('int' === $type) { | ||
if (!is_numeric($id)) { | ||
return null; | ||
} | ||
$enum = $resourceClass::tryFrom((int) $id); | ||
} else { | ||
$enum = $resourceClass::tryFrom($id); | ||
} | ||
|
||
// @deprecated enums will be indexable only by value in 4.0 | ||
$enum ??= array_reduce($resourceClass::cases(), static fn ($c, \BackedEnum $case) => $id === $case->name ? $case : $c, null); | ||
|
||
return $enum; | ||
} | ||
} |
Original file line number | Diff line number | Diff line change | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -25,6 +25,11 @@ | |||||||||||
<argument type="service" id="translator" on-invalid="null" /> | ||||||||||||
</service> | ||||||||||||
|
||||||||||||
<service id="api_platform.state_provider.backed_enum" class="ApiPlatform\State\Provider\BackedEnumProvider"> | ||||||||||||
<tag name="api_platform.state_provider" key="ApiPlatform\State\Provider\BackedEnumProvidevr" /> | ||||||||||||
<tag name="api_platform.state_provider" key="api_platform.state_provider.backed_enum" /> | ||||||||||||
</service> | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For the record @GwendolenLynch instead of decorating the provider chain, I choose to declare this as an operation provider instead. This will be called inside the ReadProvider: core/src/State/Provider/ReadProvider.php Lines 75 to 79 in ef4812a
It's easier for userland to decorate our enum provider (or any item provider) instead of hooking into the main decoration chain. |
||||||||||||
|
||||||||||||
<service id="api_platform.error_listener" class="ApiPlatform\Symfony\EventListener\ErrorListener"> | ||||||||||||
<argument key="$controller">api_platform.symfony.main_controller</argument> | ||||||||||||
<argument key="$logger" type="service" id="logger" on-invalid="null" /> | ||||||||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the API Platform project. | ||
* | ||
* (c) Kévin Dunglas <dunglas@gmail.com> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
declare(strict_types=1); | ||
|
||
namespace ApiPlatform\Tests\Fixtures\TestBundle\ApiResource; | ||
|
||
use ApiPlatform\Metadata\ApiResource; | ||
|
||
#[ApiResource] | ||
enum BackedEnumIntegerResource: int | ||
{ | ||
case Yes = 1; | ||
case No = 2; | ||
case Maybe = 3; | ||
|
||
public function getDescription(): string | ||
{ | ||
return match ($this) { | ||
self::Yes => 'We say yes', | ||
self::No => 'Computer says no', | ||
self::Maybe => 'Let me think about it', | ||
}; | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the API Platform project. | ||
* | ||
* (c) Kévin Dunglas <dunglas@gmail.com> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
declare(strict_types=1); | ||
|
||
namespace ApiPlatform\Tests\Fixtures\TestBundle\ApiResource; | ||
|
||
use ApiPlatform\Metadata\ApiResource; | ||
|
||
#[ApiResource] | ||
enum BackedEnumStringResource: string | ||
{ | ||
case Yes = 'yes'; | ||
case No = 'no'; | ||
case Maybe = 'maybe'; | ||
|
||
public function getDescription(): string | ||
{ | ||
return match ($this) { | ||
self::Yes => 'We say yes', | ||
self::No => 'Computer says no', | ||
self::Maybe => 'Let me think about it', | ||
}; | ||
} | ||
} |
Original file line number | Diff line number | Diff line change | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,49 @@ | ||||||||||||||||||
<?php | ||||||||||||||||||
|
||||||||||||||||||
/* | ||||||||||||||||||
* This file is part of the API Platform project. | ||||||||||||||||||
* | ||||||||||||||||||
* (c) Kévin Dunglas <dunglas@gmail.com> | ||||||||||||||||||
* | ||||||||||||||||||
* For the full copyright and license information, please view the LICENSE | ||||||||||||||||||
* file that was distributed with this source code. | ||||||||||||||||||
*/ | ||||||||||||||||||
|
||||||||||||||||||
declare(strict_types=1); | ||||||||||||||||||
|
||||||||||||||||||
namespace ApiPlatform\Tests\Fixtures\TestBundle\ApiResource\Issue6264; | ||||||||||||||||||
|
||||||||||||||||||
use ApiPlatform\Metadata\Operation; | ||||||||||||||||||
use Symfony\Component\Serializer\Attribute\Groups; | ||||||||||||||||||
|
||||||||||||||||||
trait BackedEnumStringTrait | ||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For further readers, this was duplicated from the BackedEnumTrait as graphql "guesses" the type from an union: core/src/GraphQl/Type/FieldsBuilder.php Lines 232 to 239 in ef4812a
I'm not a huge fan, ideally we should provide a fix at some point there, even though when representing resources one should avoid scalar union types in my opinion. |
||||||||||||||||||
{ | ||||||||||||||||||
public static function values(): array | ||||||||||||||||||
{ | ||||||||||||||||||
return array_map(static fn (\BackedEnum $feature) => $feature->value, self::cases()); | ||||||||||||||||||
} | ||||||||||||||||||
|
||||||||||||||||||
public function getId(): string | ||||||||||||||||||
{ | ||||||||||||||||||
return $this->value; | ||||||||||||||||||
} | ||||||||||||||||||
|
||||||||||||||||||
#[Groups(['get'])] | ||||||||||||||||||
public function getValue(): string | ||||||||||||||||||
{ | ||||||||||||||||||
return $this->value; | ||||||||||||||||||
} | ||||||||||||||||||
|
||||||||||||||||||
public static function getCases(): array | ||||||||||||||||||
{ | ||||||||||||||||||
return self::cases(); | ||||||||||||||||||
} | ||||||||||||||||||
|
||||||||||||||||||
/** | ||||||||||||||||||
* @param array<string, string> $uriVariables | ||||||||||||||||||
*/ | ||||||||||||||||||
public static function getCase(Operation $operation, array $uriVariables): ?self | ||||||||||||||||||
{ | ||||||||||||||||||
return array_reduce(self::cases(), static fn ($c, \BackedEnum $case) => $case->value == $uriVariables['id'] ? $case : $c, null); | ||||||||||||||||||
} | ||||||||||||||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not work if there are no GraphQlOperations