Skip to content

Update path client/ to pwa/ #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wiese opened this issue Nov 3, 2021 · 1 comment
Open

Update path client/ to pwa/ #1462

wiese opened this issue Nov 3, 2021 · 1 comment

Comments

@wiese
Copy link
Contributor

wiese commented Nov 3, 2021

Apparently, the path and service name client was changed to pwa in the past.

The docs repo still mentions the old name in some places.

$ grep -r "client/"
deployment/traefik.md:Then you edited your `admin/Dockerfile` and `client/Dockerfile` like this:
client-generator/react.md:// client/src/index.js
client-generator/vuetify.md:// client/src/config/entrypoint.js
…

$ grep -r 'client\\'
client-generator/vuetify.md:Remove the directories `client\src\` and `client\public\` and the files `client\package.json\` and `client\yarn.lock\`  (because the distribution comes with a prebuilt react app.)

$ grep -r "docker-compose exec client"
client-generator/react.md:docker-compose exec client
client-generator/vuetify.md:docker-compose exec client
client-generator/vuetify.md:docker-compose exec client
client-generator/vuetify.md:docker-compose exec client
client-generator/vuetify.md:docker-compose exec client

Work on this topic was previously done in e.g. #1294 but this was closed already.

Would a PR for this issue be welcome?

@alanpoulain
Copy link
Member

Hello,
Sure, you are welcome to do it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants