Skip to content

fix(apisix): transform client TLS certificate pairs when dump upstream #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bzp2010 merged 1 commit into from
Dec 8, 2025
Merged

fix(apisix): transform client TLS certificate pairs when dump upstream #395

bzp2010 merged 1 commit into from
Dec 8, 2025

Conversation

@bzp2010
Copy link
Collaborator

@bzp2010 bzp2010 commented Dec 8, 2025

Description

Correctly convert inline client TLS certificate pairs when dumping upstream from the APISIX backend.

According to the ADC schema, these should be client_cert and client_key, consistent with the original Admin API. Do not use cert and key.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible

@bzp2010 bzp2010 merged commit 9c173c0 into main Dec 8, 2025
24 checks passed
@bzp2010 bzp2010 deleted the bzp/fix-ba-transform-upstream-tls-client-cert-key branch December 8, 2025 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guoqqqi guoqqqi guoqqqi approved these changes

@juzhiyuan juzhiyuan Awaiting requested review from juzhiyuan

@LiteSun LiteSun Awaiting requested review from LiteSun

@SkyeYoung SkyeYoung Awaiting requested review from SkyeYoung

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bzp2010 @guoqqqi