Skip to content

Rename Actor interface so that it doesn't clash with the SDK #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
janbuchar opened this issue Feb 21, 2025 · 1 comment
Open

Rename Actor interface so that it doesn't clash with the SDK #644

janbuchar opened this issue Feb 21, 2025 · 1 comment
Labels
t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@janbuchar
Copy link
Contributor

See https://github.com/apify/apify-client-js/blob/master/src/resource_clients/actor.ts#L224 - the interface Actor returned from ActorClient.get could benefit from being renamed to e.g. ActorResponse or ActorData.

Stems from feedback by @Jkuzz - https://apify.slack.com/archives/CD0SF6KD4/p1740146722916739
@B4nan B4nan added the t-tooling Issues with this label are in the ownership of the tooling team. label Mar 17, 2025
@B4nan
Copy link
Member

B4nan commented Mar 17, 2025

potentially breaking, lets wait for major bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@janbuchar @B4nan