feat: sign record's public url #358
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| import { createHmacSignature } from '@apify/utilities'; | ||
| import type { StorageManagerOptions } from '@crawlee/core'; | ||
| import { KeyValueStore as CoreKeyValueStore } from '@crawlee/core'; | ||
|
|
||
|
|
@@ -19,7 +20,13 @@ export class KeyValueStore extends CoreKeyValueStore { | |
| return getPublicUrl.call(this, key); | ||
| } | ||
|
|
||
| const publicUrl = new URL(`https://api.apify.com/v2/key-value-stores/${this.id}/records/${key}`); | ||
|
There was a problem hiding this comment. (nit) Isn't the API base URL available in the env variables? That way the Actor will create valid urls in all environments. You could leverage that to create an actual e2e test that not only creates & runs an Actor that produces the signed URL, but actually tests the URL against Apify API. (The current test below basically just copies the implementation... you are calling the same code twice and checking that it produces the same value 😅 ) There was a problem hiding this comment. i think there was a reason for this. if you ask what reason, i have no idea, but there is something at the back of my mind telling me there was one 🙃 There was a problem hiding this comment. @B4nan I think it should be safe to use |
||
|
|
||
| if (this.storageObject?.urlSigningSecretKey) { | ||
| publicUrl.searchParams.append('signature', createHmacSignature(this.storageObject.urlSigningSecretKey as string, key)); | ||
| } | ||
|
|
||
| return publicUrl.toString(); | ||
| } | ||
|
|
||
| /** | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and don't forget to bump this