Skip to content

chore: Update Crawlee and fix related issues #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 1, 2025
Merged

chore: Update Crawlee and fix related issues #373

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
738873a
fix: CI
danpoletaev Mar 31, 2025
bace882
Fix PlatformEventManager test
janbuchar Mar 31, 2025
c3b27a9
Lint
janbuchar Mar 31, 2025
8fb10ca
Update test/apify/events.test.ts
janbuchar Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/actor-scraper/puppeteer-scraper/src/internals/crawler_setup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ export class CrawlerSetup implements CrawlerSetupOptions {
launchContext: {
useChrome: this.input.useChrome,
launchOptions: {
ignoreHTTPSErrors: this.input.ignoreSslErrors,
acceptInsecureCerts: this.input.ignoreSslErrors,
defaultViewport: DEFAULT_VIEWPORT,
devtools: this.devtools,
args,
Expand Down
2 changes: 1 addition & 1 deletion packages/actor-scraper/web-scraper/src/internals/crawler_setup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ export class CrawlerSetup implements CrawlerSetupOptions {
launchContext: {
useChrome: this.input.useChrome,
launchOptions: {
ignoreHTTPSErrors: this.input.ignoreSslErrors,
acceptInsecureCerts: this.input.ignoreSslErrors,
defaultViewport: DEFAULT_VIEWPORT,
args,
headless: this.input.headless,
Expand Down
2 changes: 1 addition & 1 deletion packages/apify/src/proxy_configuration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ export class ProxyConfiguration extends CoreProxyConfiguration {
return this._handleTieredUrl(
sessionId ?? cryptoRandomObjectId(6),
options,
).proxyUrl;
).proxyUrl ?? undefined;
}

return this.composeDefaultUrl(sessionId);
Expand Down
14 changes: 9 additions & 5 deletions test/apify/events.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,13 @@ import { WebSocketServer } from 'ws';
describe('events', () => {
let wss: WebSocketServer = null;
const config = Configuration.getGlobalConfig();
const events = new PlatformEventManager(config);
config.useEventManager(events);
let events: PlatformEventManager = null;

beforeEach(() => {
wss = new WebSocketServer({ port: 9099 });
events = new PlatformEventManager(config);
config.useEventManager(events);

vitest.useFakeTimers();
process.env[ACTOR_ENV_VARS.EVENTS_WEBSOCKET_URL] = 'ws://localhost:9099/someRunId';
process.env[APIFY_ENV_VARS.TOKEN] = 'dummy';
Expand Down Expand Up @@ -112,11 +114,13 @@ describe('events', () => {

test('should send persist state events in regular interval', async () => {
const eventsReceived = [];
const interval = config.get('persistStateIntervalMillis');

events.on(EventType.PERSIST_STATE, (data) => eventsReceived.push(data));
await events.init();
vitest.advanceTimersByTime(60001);
vitest.advanceTimersByTime(60001);
vitest.advanceTimersByTime(60001);
await vitest.advanceTimersByTimeAsync(1.1 * interval);
await vitest.advanceTimersByTimeAsync(1.1 * interval);
await vitest.advanceTimersByTimeAsync(1.1 * interval);
await events.close();
expect(eventsReceived.length).toBe(5);
});
Expand Down
Loading