-
Notifications
You must be signed in to change notification settings - Fork 45
chore(ci): add automatic release workflow for generic Actors #380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
version: | ||
description: Version to build | ||
type: string | ||
required: true | ||
default: '3.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how does this work? some of the scrapers are on a lower version since they are newer, e.g. playwright and jsdom
also can this be used to trigger the development build of all of them at once?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some of the scrapers are on a lower version since they are newer, e.g. playwright and jsdom
Ah, that's annoying, and I missed that. We can omit the version param altogether if we set the version right in the .apify/actor.json
file. Right now, there's just a bunch of top-level apify.json
files.
also can this be used to trigger the development build of all of them at once?
I don't see why not, even though we'll need to make sure all the development
versions match.
Thinking about it now, it might be better to replace the build-tag
and version
options with a "build type" choice
(picker with latest
/ beta
/ canary
or something similar) and have the logic in the action internally. We might want to match all the Actor versions on the platform, so the implementation is easier, but I'm not sure about the implications of this.
Co-authored-by: Jan Buchar <jan.buchar@apify.com>
Fixes the missing pieces from #380 . Fixes the Camoufox scraper internals and dependencies.
Adds a manual-dispatch CI workflow for running generic Actor builds on Apify.