Skip to content

chore(ci): add automatic release workflow for generic Actors #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 23, 2025

Conversation

barjin
Copy link
Contributor

@barjin barjin commented Apr 22, 2025

Adds a manual-dispatch CI workflow for running generic Actor builds on Apify.

@barjin barjin added the adhoc Ad-hoc unplanned task added during the sprint. label Apr 22, 2025
@barjin barjin self-assigned this Apr 22, 2025
@github-actions github-actions bot added this to the 113rd sprint - Tooling team milestone Apr 22, 2025
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Apr 22, 2025
@barjin barjin requested review from janbuchar and B4nan April 22, 2025 12:19
Comment on lines 36 to 40
version:
description: Version to build
type: string
required: true
default: '3.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does this work? some of the scrapers are on a lower version since they are newer, e.g. playwright and jsdom

also can this be used to trigger the development build of all of them at once?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some of the scrapers are on a lower version since they are newer, e.g. playwright and jsdom

Ah, that's annoying, and I missed that. We can omit the version param altogether if we set the version right in the .apify/actor.json file. Right now, there's just a bunch of top-level apify.json files.

also can this be used to trigger the development build of all of them at once?

I don't see why not, even though we'll need to make sure all the development versions match.

Thinking about it now, it might be better to replace the build-tag and version options with a "build type" choice (picker with latest / beta / canary or something similar) and have the logic in the action internally. We might want to match all the Actor versions on the platform, so the implementation is easier, but I'm not sure about the implications of this.

Co-authored-by: Jan Buchar <jan.buchar@apify.com>
@barjin barjin merged commit 62fdb4d into master Apr 23, 2025
9 checks passed
@barjin barjin deleted the chore/automatic-actor-build branch April 23, 2025 11:16
barjin added a commit that referenced this pull request Apr 23, 2025
Fixes the missing pieces from #380 . Fixes the Camoufox scraper internals and dependencies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants