-
Notifications
You must be signed in to change notification settings - Fork 46
chore(ci): add automatic release workflow for generic Actors #380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
f329968
chore(ci): add automatic release workflow for generic Actors
barjin b7b33a7
feat: add build channel option and automatic version computation
barjin 0061bfa
chore: test workflow by running it on `push`
barjin c839d57
chore: skip build if `should-build` is `false`
barjin 6404f90
chore: debugging
barjin dfc1672
chore: try renaming files to enable the `workflow_dispatch` UI
barjin fdf46b9
chore: revert debugging changes, prepare for merge
barjin 5d071b2
chore: migrate generic Actors to `.apify/actor.json` manifest
barjin d28fd3f
chore: code style
barjin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| name: Build generic Actors | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| web-scraper: | ||
| description: apify/web-scraper | ||
| type: boolean | ||
| required: false | ||
| default: true | ||
| cheerio-scraper: | ||
| description: apify/cheerio-scraper | ||
| type: boolean | ||
| required: false | ||
| default: true | ||
| playwright-scraper: | ||
| description: apify/playwright-scraper | ||
| type: boolean | ||
| required: false | ||
| default: true | ||
| puppeteer-scraper: | ||
| description: apify/puppeteer-scraper | ||
| type: boolean | ||
| required: false | ||
| default: true | ||
| jsdom-scraper: | ||
| description: apify/jsdom-scraper | ||
| type: boolean | ||
| required: false | ||
| default: true | ||
| camoufox-scraper: | ||
| description: apify/camoufox-scraper | ||
| type: boolean | ||
| required: false | ||
| default: true | ||
| version: | ||
| description: Version to build | ||
| type: string | ||
| required: true | ||
| default: '3.0' | ||
| build-tag: | ||
| description: Build tag | ||
| type: string | ||
| required: true | ||
| default: version-3 | ||
|
|
||
| jobs: | ||
| push-to-apify: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| settings: | ||
| - actor: web-scraper | ||
| should-build: ${{ github.event.inputs.web-scraper }} | ||
| - actor: cheerio-scraper | ||
| should-build: ${{ github.event.inputs.cheerio-scraper }} | ||
| - actor: playwright-scraper | ||
| should-build: ${{ github.event.inputs.playwright-scraper }} | ||
| - actor: puppeteer-scraper | ||
| should-build: ${{ github.event.inputs.puppeteer-scraper }} | ||
| - actor: jsdom-scraper | ||
| should-build: ${{ github.event.inputs.jsdom-scraper }} | ||
| - actor: camoufox-scraper | ||
| should-build: ${{ github.event.inputs.camoufox-scraper }} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Build ${{ matrix.settings.actor }} | ||
| uses: apify/push-actor-action@master | ||
| if: matrix.settings.should-build == 'true' | ||
| with: | ||
| token: ${{ secrets.APIFY_ACTOR_BUILD_TOKEN }} | ||
| build-tag: ${{ github.event.inputs.build-tag }} | ||
| version: ${{ github.event.inputs.version }} | ||
| working-directory: packages/actor-scraper/${{ matrix.settings.actor }} | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how does this work? some of the scrapers are on a lower version since they are newer, e.g. playwright and jsdom
also can this be used to trigger the development build of all of them at once?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that's annoying, and I missed that. We can omit the version param altogether if we set the version right in the
.apify/actor.jsonfile. Right now, there's just a bunch of top-levelapify.jsonfiles.I don't see why not, even though we'll need to make sure all the
developmentversions match.Thinking about it now, it might be better to replace the
build-tagandversionoptions with a "build type"choice(picker withlatest/beta/canaryor something similar) and have the logic in the action internally. We might want to match all the Actor versions on the platform, so the implementation is easier, but I'm not sure about the implications of this.