Skip to content

chore(ci): fix automatic Actor build versioning #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 23, 2025

Conversation

barjin
Copy link
Contributor

@barjin barjin commented Apr 23, 2025

Fixes the missing pieces from #380 . Fixes the Camoufox scraper internals and dependencies.

@barjin barjin added the adhoc Ad-hoc unplanned task added during the sprint. label Apr 23, 2025
@barjin barjin requested a review from Copilot April 23, 2025 13:04
@barjin barjin self-assigned this Apr 23, 2025
@github-actions github-actions bot added this to the 113rd sprint - Tooling team milestone Apr 23, 2025
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Apr 23, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses CI configuration improvements by fixing the automatic Actor build versioning, as well as updating the Camoufox scraper internals and dependencies.

  • Update version values to quoted strings for consistency.
  • Refactor shell script logic to use stricter equality comparison and assign environment variables without appended newlines.
Files not reviewed (2)
  • packages/actor-scraper/camoufox-scraper/Dockerfile: Language not supported
  • packages/actor-scraper/camoufox-scraper/package.json: Language not supported

@barjin barjin merged commit 731787a into master Apr 23, 2025
9 checks passed
@barjin barjin deleted the chore/automatic-actor-versioning-fix branch April 23, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant