Skip to content

chore(ci): fix automatic Actor build versioning #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 23, 2025
Merged

chore(ci): fix automatic Actor build versioning #381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f75914a
chore(ci): fix automatic Actor build versioning
barjin Apr 23, 2025
777ccbf
chore: CI workflow syntax
barjin Apr 23, 2025
5bc1d4b
chore: fix `camoufox-scraper` browser install
barjin Apr 23, 2025
24d79f4
chore: bump `camoufox-js` version
barjin Apr 23, 2025
fc3b14f
chore: code style
barjin Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions .github/workflows/release-generic-actors.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,39 +60,39 @@ jobs:
matrix:
settings:
- actor: web-scraper
stable-version: 3.0
stable-version: '3.0'
stable-build-tag: version-3
development-version: 0.0
development-version: '0.0'
development-build-tag: development
should-build: ${{ github.event.inputs.web-scraper }}
- actor: cheerio-scraper
stable-version: 3.0
stable-version: '3.0'
stable-build-tag: version-3
development-version: 0.0
development-version: '0.0'
development-build-tag: development
should-build: ${{ github.event.inputs.cheerio-scraper }}
- actor: playwright-scraper
stable-version: 1.0
stable-version: '1.0'
stable-build-tag: version-1
development-version: 0.0
development-version: '0.0'
development-build-tag: development
should-build: ${{ github.event.inputs.playwright-scraper }}
- actor: puppeteer-scraper
stable-version: 3.0
stable-version: '3.0'
stable-build-tag: version-3
development-version: 0.0
development-version: '0.0'
development-build-tag: development
should-build: ${{ github.event.inputs.puppeteer-scraper }}
- actor: jsdom-scraper
stable-version: 0.1
stable-version: '0.1'
stable-build-tag: latest
development-version: 0.0
development-version: '0.0'
development-build-tag: development
should-build: ${{ github.event.inputs.jsdom-scraper }}
- actor: camoufox-scraper
stable-version: 3.0
stable-version: '3.0'
stable-build-tag: version-3
development-version: 0.0
development-version: '0.0'
development-build-tag: development
should-build: ${{ github.event.inputs.camoufox-scraper }}
steps:
Expand All @@ -108,21 +108,21 @@ jobs:
if: matrix.settings.should-build == 'true'
run: |
if [ "${{ github.event.inputs.build-channel }}" = "stable" ]; then
echo "version=${{ matrix.settings.stable-version }}\n" >> $GITHUB_ENV
echo "build-tag=${{ matrix.settings.stable-build-tag }}\n" >> $GITHUB_ENV
echo "version=${{ matrix.settings.stable-version }}" >> $GITHUB_ENV
echo "build-tag=${{ matrix.settings.stable-build-tag }}" >> $GITHUB_ENV
elif [ "${{ github.event.inputs.build-channel }}" = "development" ]; then
echo "version=${{ matrix.settings.development-version }}\n" >> $GITHUB_ENV
echo "build-tag=${{ matrix.settings.development-build-tag }}\n" >> $GITHUB_ENV
echo "version=${{ matrix.settings.development-version }}" >> $GITHUB_ENV
echo "build-tag=${{ matrix.settings.development-build-tag }}" >> $GITHUB_ENV
else
echo "version=${{ github.event.inputs.version }}\n" >> $GITHUB_ENV
echo "build-tag=${{ github.event.inputs.build-tag }}\n" >> $GITHUB_ENV
echo "version=${{ github.event.inputs.version }}" >> $GITHUB_ENV
echo "build-tag=${{ github.event.inputs.build-tag }}" >> $GITHUB_ENV
fi

- name: Build ${{ matrix.settings.actor }}
uses: apify/push-actor-action@master
if: matrix.settings.should-build == 'true'
with:
token: ${{ secrets.APIFY_ACTOR_BUILD_TOKEN }}
build-tag: ${{ steps.calculate-versions.outputs.build-tag }}
version: ${{ steps.calculate-versions.outputs.version }}
build-tag: ${{ env.build-tag }}
version: ${{ env.version }}
working-directory: packages/actor-scraper/${{ matrix.settings.actor }}
87 changes: 63 additions & 24 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions packages/actor-scraper/camoufox-scraper/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ RUN npm --quiet set progress=false \
&& npm --version \
&& rm -r ~/.npm

ENV PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD=0
RUN npm run get-binaries

COPY --chown=myuser . ./
Expand Down
2 changes: 1 addition & 1 deletion packages/actor-scraper/camoufox-scraper/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"@crawlee/playwright": "^3.13.2",
"@crawlee/utils": "^3.13.2",
"apify": "^3.2.6",
"camoufox-js": "^0.3.0",
"camoufox-js": "^0.3.4",
"idcac-playwright": "^0.1.3",
"playwright": "*"
},
Expand Down
Loading