feat(consts): add user env vars for tiered pricing #511
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stetizu1
commented
Apr 25, 2025
Comment on lines
+282
to
+287
| LOG_LEVEL: 'APIFY_LOG_LEVEL', | ||
| METAMORPH_AFTER_SLEEP_MILLIS: 'APIFY_METAMORPH_AFTER_SLEEP_MILLIS', | ||
| META_ORIGIN: 'APIFY_META_ORIGIN', | ||
| PERSIST_STATE_INTERVAL_MILLIS: 'APIFY_PERSIST_STATE_INTERVAL_MILLIS', | ||
| PROXY_PASSWORD: 'APIFY_PROXY_PASSWORD', | ||
| PROXY_HOSTNAME: 'APIFY_PROXY_HOSTNAME', | ||
| PROXY_PASSWORD: 'APIFY_PROXY_PASSWORD', |
There was a problem hiding this comment.
Just sorted lines here 😅
| PROXY_PORT: 'APIFY_PROXY_PORT', | ||
| PROXY_STATUS_URL: 'APIFY_PROXY_STATUS_URL', | ||
| PURGE_ON_START: 'APIFY_PURGE_ON_START', | ||
| SDK_LATEST_VERSION: 'APIFY_SDK_LATEST_VERSION', | ||
| SYSTEM_INFO_INTERVAL_MILLIS: 'APIFY_SYSTEM_INFO_INTERVAL_MILLIS', | ||
| TOKEN: 'APIFY_TOKEN', | ||
| USER_ID: 'APIFY_USER_ID', | ||
| USER_IS_PAYING: 'APIFY_USER_IS_PAYING', |
There was a problem hiding this comment.
How does this relate to API permissions @tobice pls check this as well
There was a problem hiding this comment.
Actually pretty well... it's the same situation as with the proxy password. This eliminates the need for Actors to fetch it from API, and for us to create a scope for it 🤔
jirimoravcik
changed the title
jirimoravcik
changed the title
jancurn
requested changes
Apr 25, 2025
packages/consts/src/consts.ts
Outdated
| PROXY_PORT: 'APIFY_PROXY_PORT', | ||
| PROXY_STATUS_URL: 'APIFY_PROXY_STATUS_URL', | ||
| PURGE_ON_START: 'APIFY_PURGE_ON_START', | ||
| SDK_LATEST_VERSION: 'APIFY_SDK_LATEST_VERSION', | ||
| SYSTEM_INFO_INTERVAL_MILLIS: 'APIFY_SYSTEM_INFO_INTERVAL_MILLIS', | ||
| TOKEN: 'APIFY_TOKEN', | ||
| USER_ID: 'APIFY_USER_ID', | ||
| USER_IS_PAYING: 'APIFY_USER_IS_PAYING', | ||
| USER_TIER: 'APIFY_USER_TIER', |
There was a problem hiding this comment.
This is a terrible name, by reading it you have no idea what it means. It should really be APIFY_USER_PRICING_TIER
mtrunkat
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of: https://github.com/apify/apify-core/issues/19616
adds tier and user is paying vars