Open
Conversation
barjin
requested changes
Dec 18, 2025
Comment on lines
+16
to
+18
| const extractValue = (elem: any) => { | ||
| return $(elem).attr('content') || $(elem).text()?.trim() || $(elem).attr('src') || $(elem).attr('href') || null; | ||
| }; |
Member
There was a problem hiding this comment.
This is not entirely correct as per the microdata specification. See point 5.2.4 Values - the type of the value extracted is based on the element type.
| }; | ||
|
|
||
| const extractItem = (elem: any): any => { | ||
| const item: any = { _type: $(elem).attr('itemtype') }; |
Member
There was a problem hiding this comment.
As per the spec, itemtype is a unordered set of unique space-separated tokens, we should split this by ASCII whitespace.
| return $(this).parentsUntil(elem, '[itemscope]').length === 0; | ||
| }) | ||
| .each(function () { | ||
| const propName = $(this).attr('itemprop'); |
Member
There was a problem hiding this comment.
itemprop is also an unordered set of unique space-separated tokens, this needs to be split too - see example (link):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces #276
ATM only extracts micordata from schema.org and no JSON-LD or RDFa.
Did I write the tests as of now?
No