Skip to content

Conversation

@berramou
Copy link

@berramou berramou commented Nov 1, 2025

Fixes #1198

@google-cla
Copy link

google-cla bot commented Nov 1, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov
Copy link

codecov bot commented Nov 1, 2025

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.36%. Comparing base (b8b6778) to head (8328e5a).

Files with missing lines Patch % Lines
src/Form/DeveloperAttributesSettingsForm.php 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                4.x    #1199      +/-   ##
============================================
- Coverage     43.54%   42.36%   -1.18%     
  Complexity     3074     3074              
============================================
  Files           343      343              
  Lines         11253    11243      -10     
============================================
- Hits           4900     4763     -137     
- Misses         6353     6480     +127     
Files with missing lines Coverage Δ
src/Form/DeveloperAttributesSettingsForm.php 0.00% <0.00%> (ø)

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use FieldAttributeConverterInterface instead of concrete FieldAttributeConverter class in constructor injection

1 participant