Skip to content

Use FieldAttributeConverterInterface instead of concrete class for constructor injection #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 7, 2025
Merged

Use FieldAttributeConverterInterface instead of concrete class for constructor injection #1199

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8328e5a
Use FieldAttributeConverterInterface instead of concrete FieldAttribu…
berramou Nov 1, 2025
42dd416
Merge branch '4.x' into feature/use-fieldattributeconverterinterface
shishir-intelli Nov 6, 2025
a21d7b8
Fix phpcs issues
berramou Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/Form/DeveloperAttributesSettingsForm.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
use Drupal\Core\Form\ConfigFormBase;
use Drupal\Core\Form\FormStateInterface;
use Drupal\Core\Url;
use Drupal\apigee_edge\FieldAttributeConverter;
use Drupal\apigee_edge\FieldAttributeConverterInterface;
use Drupal\apigee_edge\Plugin\FieldStorageFormatManagerInterface;
use Drupal\field\Entity\FieldConfig;
use Drupal\field\FieldConfigInterface;
Expand Down Expand Up @@ -66,12 +66,18 @@ class DeveloperAttributesSettingsForm extends ConfigFormBase {
* Entity field manager service.
* @param \Drupal\apigee_edge\Plugin\FieldStorageFormatManagerInterface $field_storage_format_manager
* Field storage format manager service.
* @param \Drupal\apigee_edge\FieldAttributeConverter $field_attribute_converter
* @param \Drupal\apigee_edge\FieldAttributeConverterInterface $field_attribute_converter
* Field name to attribute name converted service.
* @param \Drupal\Core\Config\TypedConfigManagerInterface $typed_config_manager
* The typed config manager.
*/
public function __construct(ConfigFactoryInterface $config_factory, EntityFieldManagerInterface $entity_field_manager, FieldStorageFormatManagerInterface $field_storage_format_manager, FieldAttributeConverter $field_attribute_converter, TypedConfigManagerInterface $typed_config_manager) {
public function __construct(
ConfigFactoryInterface $config_factory,
EntityFieldManagerInterface $entity_field_manager,
FieldStorageFormatManagerInterface $field_storage_format_manager,
FieldAttributeConverterInterface $field_attribute_converter,
TypedConfigManagerInterface $typed_config_manager,
) {
parent::__construct($config_factory, $typed_config_manager);
$this->fieldAttributeConverter = $field_attribute_converter;
$this->entityFieldManager = $entity_field_manager;
Expand Down