Merge branch 'php-last' into development

Author: natanfelles

.github/workflows/tests.yml

@@ -13,10 +13,8 @@ jobs:
 
     strategy:
       fail-fast: true
-      matrix:
-        php: ['8.1']
 
-    name: PHP ${{ matrix.php }}
+    name: PHP 8.1
 
     steps:
       - name: Checkout
@@ -25,7 +23,7 @@ jobs:
       - name: Setup PHP
         uses: shivammathur/setup-php@v2
         with:
-          php-version: ${{ matrix.php }}
+          php-version: 8.1
           tools: composer
           coverage: xdebug
 
@@ -60,4 +58,30 @@ jobs:
           cp build/coverage/clover.xml build/logs/clover.xml
           composer global require php-coveralls/php-coveralls
           php-coveralls --coverage_clover=build/logs/clover.xml -v
-        if: matrix.php == '8.1'
+
+  tests-last:
+    runs-on: ubuntu-20.04
+    timeout-minutes: 10
+
+    strategy:
+      fail-fast: true
+
+    name: PHP 8.2 - Last
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: 8.2
+          tools: composer
+          coverage: xdebug
+
+      - name: Install dependencies
+        run:
+          composer update
+
+      - name: PHPUnit
+        run: vendor/bin/phpunit --verbose

.gitlab-ci.yml

@@ -15,6 +15,7 @@ test:php:
       - build/
       - vendor/
   before_script:
+    - php -v
     - composer update
   script:
     - composer normalize --dry-run --indent-size=4 --indent-style=space
@@ -29,6 +30,20 @@ test:php:
       - build/docs/
   coverage: '/^\s*Lines:\s*\d+.\d+\%/'
 
+test:php-last:
+  image: registry.gitlab.com/aplus-framework/images/base:3
+  stage: test
+  timeout: 10 minutes
+  cache:
+    paths:
+      - vendor/
+  before_script:
+    - php -v
+    - composer update
+  script:
+    - vendor/bin/phpunit --colors=never
+  coverage: '/^\s*Lines:\s*\d+.\d+\%/'
+
 pages:
   stage: deploy
   timeout: 10 minutes

docker-compose.yml

@@ -7,3 +7,10 @@ services:
     volumes:
       - .:/package
     tty: true
+  package-last:
+    image: registry.gitlab.com/aplus-framework/images/package:3
+    container_name: package-validation-last
+    working_dir: /package
+    volumes:
+      - .:/package
+    tty: true

src/Validator.php

@@ -408,8 +408,10 @@ public static function datetime(
             return false;
         }
         $lastErrors = \DateTime::getLastErrors();
-        return $lastErrors
-            && $lastErrors['warning_count'] === 0
+        if ($lastErrors === false) {
+            return true;
+        }
+        return $lastErrors['warning_count'] === 0
             && $lastErrors['error_count'] === 0;
     }
 

tests/ValidatorTest.php

@@ -182,6 +182,9 @@ public function testDatetime() : void
         self::assertTrue(Validator::datetime('year', $this->array, 'Y'));
         self::assertFalse(Validator::datetime('alpha', $this->array));
         self::assertFalse(Validator::datetime('unknown', $this->array));
+        self::assertFalse(Validator::datetime('foo', [
+            'foo' => '2022-02-29 25:10:10',
+        ]));
     }
 
     public function testEquals() : void