-
Notifications
You must be signed in to change notification settings - Fork 21
split execute and instrospection #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
0b65cf0
to
28e51fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, we need to add this to the docs
Is there a docs preview generated somewhere 👀 |
### ❗ BREAKING ❗ | ||
- split out the execute tool into separate --execute-introspection flag, `--introspection` is now `--introspection --execute-introspection` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm starting to have second thoughts about this. It may confuse people if this stops working, and it's yet more options they have to enable. I wonder if we could leave ---introspection
as is, but then add --introspect
and ---execute
to override and enable/disable individual tools? The clients also generally have a way to disable specific tools.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, we have the same option in rover, and would need an update there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chatted about this in standup but, but for the history I agree! we are going to try to do a backwards compatible enum here and as a fallback we could add a --disable-execute
instead
split execute and introspection into 2 arguments. Going to wait and rebase on https://github.com/apollographql/apollo-mcp-server/pull/44