Skip to content

split execute and instrospection #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Jephuff
Copy link
Contributor

@Jephuff Jephuff commented May 9, 2025

@Jephuff Jephuff force-pushed the jeffrey/split-schema-and-execute branch from 0b65cf0 to 28e51fd Compare May 20, 2025 18:24
@Jephuff Jephuff marked this pull request as ready for review May 20, 2025 18:32
@Jephuff Jephuff requested a review from a team as a code owner May 20, 2025 18:32
Copy link
Contributor

@pubmodmatt pubmodmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, we need to add this to the docs

@Jephuff Jephuff requested a review from a team as a code owner May 22, 2025 22:24
@Jephuff Jephuff requested a review from pubmodmatt May 22, 2025 22:39
@Jephuff
Copy link
Contributor Author

Jephuff commented May 22, 2025

Is there a docs preview generated somewhere 👀

Comment on lines +18 to +20
### ❗ BREAKING ❗
- split out the execute tool into separate --execute-introspection flag, `--introspection` is now `--introspection --execute-introspection`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm starting to have second thoughts about this. It may confuse people if this stops working, and it's yet more options they have to enable. I wonder if we could leave ---introspection as is, but then add --introspect and ---execute to override and enable/disable individual tools? The clients also generally have a way to disable specific tools.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we have the same option in rover, and would need an update there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chatted about this in standup but, but for the history I agree! we are going to try to do a backwards compatible enum here and as a fallback we could add a --disable-execute instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants