Skip to content

changes to the kubernetes docs #7497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: dev
Choose a base branch
from
Draft

Conversation

lleadbet
Copy link
Contributor

@lleadbet lleadbet commented May 14, 2025

This simplifies some of the documentation on deploying Kubernetes to make it more digestible on an initial glance.

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

Copy link
Contributor

@lleadbet, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented May 14, 2025

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 4 changed, 1 removed
* graphos/routing/(latest)/customization/rhai/reference.mdx
* graphos/routing/(latest)/observability/telemetry/trace-exporters/datadog.mdx
* graphos/routing/(latest)/observability/client-id-enforcement.mdx
* graphos/routing/(latest)/self-hosted/index.mdx
- graphos/routing/(latest)/self-hosted/containerization/kubernetes.mdx

Build ID: 3c3876b2f328aa9972c213d8

URL: https://www.apollographql.com/docs/deploy-preview/3c3876b2f328aa9972c213d8

lleadbet and others added 4 commits May 19, 2025 14:44
Co-authored-by: Maria Elisabeth Schreiber <maria.schreiber@apollographql.com>
Copy link
Contributor

@garypen garypen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice improvement.

@@ -142,6 +139,7 @@ service:
type: ClusterIP
port: 80
annotations: {}
targetport: http
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without working this through totally, I think the ports are no longer wired up correctly. Have you tested that this works? I feel like the targetport should now be 4000. I could be wrong, I just wired it up in my head...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above was pulled from helm show values oci://ghcr.io/apollographql/helm-charts/router, but it is targeting port 4000 on the router pods. we have:

containerPorts:
  # -- If you override the port in `router.configuration.server.listen` then make sure to match the listen port here
  http: 4000

so we are naming the server port as http which means this mapping will just be port 4000 - even if the name is maybe a misnomer.

…ickstart.mdx

Co-authored-by: Gary Pennington <gary@apollographql.com>
@abernix abernix changed the title draft: changes to the kubernetes docs changes to the kubernetes docs May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants