-
Notifications
You must be signed in to change notification settings - Fork 297
changes to the kubernetes docs #7497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
lleadbet
wants to merge
8
commits into
dev
Choose a base branch
from
docs/deployment-adjustments
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
20aaf5a
draft: changes to the kubernetes docs
lleadbet beade6d
add sidebar
lleadbet 065bab5
Merge branch 'dev' into docs/deployment-adjustments
lleadbet 1685717
Update docs/source/_sidebar.yaml
lleadbet 231486b
move k8s docs
Meschreiber 37cbcf7
Delete duplicates
Meschreiber e990d23
pathing updates
lleadbet 45b4916
Update docs/source/routing/self-hosted/containerization/kubernetes/qu…
lleadbet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without working this through totally, I think the ports are no longer wired up correctly. Have you tested that this works? I feel like the
targetport
should now be4000
. I could be wrong, I just wired it up in my head...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The above was pulled from
helm show values oci://ghcr.io/apollographql/helm-charts/router
, but it is targeting port 4000 on the router pods. we have:so we are naming the server port as
http
which means this mapping will just be port 4000 - even if the name is maybe a misnomer.