Fix the reflection padding optimization when slice_by_index's end_mask is not specified
#2489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasper0406
changed the title
end_mask is not specifiedend_mask is not specified
TobyRoseman
reviewed
Apr 21, 2025
coremltools/converters/mil/mil/passes/defs/optimize_tensor_operation.py
Outdated
Show resolved
Hide resolved
|
Thanks for the fix @kasper0406. CI: https://gitlab.com/coremltools1/coremltools/-/pipelines/1778692443 |
|
Thanks for the update. I've kicked off another CI run: https://gitlab.com/coremltools1/coremltools/-/pipelines/1780189371 The last CI run passed. If this one passes, I will merge the PR. |
|
@TobyRoseman looks like the CI job passed, are you happy to merge this? |
TobyRoseman
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the added tests would error with an undefined attribute error, when
end_maskwas not specified on theslice_by_indexoperations.Instead of bailing out of the optimization, if
end_maskis not specified, this PR will infer the values ofend_mask.