Draft
Conversation
fboemer
force-pushed
the
fboemer/windows-ci
branch
16 times, most recently
from
6cbb5cc to
e01a207
Compare
fboemer
force-pushed
the
fboemer/windows-ci
branch
4 times, most recently
from
6876933 to
23668ef
Compare
fboemer
commented
Nov 22, 2025
| basename=$(basename "$filename" .swift) | ||
| swift run --configuration release ${basename} | ||
| done | ||
| windows_env_vars: SWIFT_HOMOMORPHIC_ENCRYPTION_ENABLE_BENCHMARKING=1 |
Contributor
Author
There was a problem hiding this comment.
- TODO: make sure that works
karulont
reviewed
Nov 25, 2025
| try sum -= sum | ||
| precondition(sum.isTransparent()) | ||
|
|
||
| preconditionFailure() |
Contributor
There was a problem hiding this comment.
Mark this with a TODO to remove it.
Comment on lines
+238
to
+239
| // Workaround SwiftPM's attempt to link in executables which does not work on all | ||
| // platforms. |
Contributor
There was a problem hiding this comment.
Can we come up with a different way to support these tests?
One option would be to split the executables into two parts: the library that will be imported to tests and a very minimal boilerplate main.swift that calls into the library.
Do we have other options?
fboemer
force-pushed
the
fboemer/windows-ci
branch
from
e7ad16a to
64a4041
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.