Skip to content

Commit f6599fd

Browse files
authored
Use weak let when available (#564)
This suppresses some warnings on newer builds.
1 parent c1bcde5 commit f6599fd

File tree

2 files changed

+15
-0
lines changed

2 files changed

+15
-0
lines changed

Tests/NIOSSLTests/ObjectIdentifierTests.swift

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,12 @@ final class ObjectIdentifierTests: XCTestCase {
7676

7777
func testUnowned() {
7878
var owner: Optional = OIDMemoryOwner("1.2.3")!
79+
80+
#if compiler(>=6.3)
81+
weak let weakReferenceToOwner = owner
82+
#else
7983
weak var weakReferenceToOwner = owner
84+
#endif
8085

8186
var oid: Optional = NIOSSLObjectIdentifier(borrowing: owner!.reference, owner: owner!)
8287
XCTAssertEqual(oid?.description, "1.2.3")
@@ -95,7 +100,12 @@ final class ObjectIdentifierTests: XCTestCase {
95100

96101
func testCopy() {
97102
var owner: Optional = OIDMemoryOwner("1.2.3")!
103+
104+
#if compiler(>=6.3)
105+
weak let weakReferenceToOwner = owner
106+
#else
98107
weak var weakReferenceToOwner = owner
108+
#endif
99109

100110
let oid: Optional = withExtendedLifetime(owner) {
101111
NIOSSLObjectIdentifier(copyOf: $0?.reference)

Tests/NIOSSLTests/SSLCertificateExtensionsTests.swift

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,12 @@ final class SSLCertificateExtensionsTests: XCTestCase {
6767

6868
func testUnowned() throws {
6969
var owner: Optional = try NIOSSLCertificate(bytes: Array(samplePemCert.utf8), format: .pem)
70+
71+
#if compiler(>=6.3)
72+
weak let weakReferenceToOwner = owner
73+
#else
7074
weak var weakReferenceToOwner = owner
75+
#endif
7176

7277
var extensions: Optional = owner!._extensions
7378
XCTAssertEqual(extensions.map { Array($0) }?.count, 3)

0 commit comments

Comments
 (0)