Skip to content

Commit 6d24ab0

Browse files
authored
[CI] Enable benchmarks & cxx Windows CI (#2940)
This PR makes it possible to enable benchmarks and cxx interop checks on Windows. By default they are turned off. This PR also fixes the job of the Windows 6 pipeline which was broken since single configuration matrix jobs seem to behave differently.
1 parent ecbb5ea commit 6d24ab0

File tree

3 files changed

+34
-2
lines changed

3 files changed

+34
-2
lines changed

.github/workflows/benchmarks.yml

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,19 @@ on:
3131
description: "Boolean to enable the Linux nightly main Swift version matrix job. Defaults to true."
3232
default: true
3333

34+
windows_6_0_enabled:
35+
type: boolean
36+
description: "Boolean to enable the Windows 6.0 Swift version matrix job. Defaults to true."
37+
default: false
38+
windows_nightly_6_0_enabled:
39+
type: boolean
40+
description: "Boolean to enable the Windows nightly 6.0 Swift version matrix job. Defaults to true."
41+
default: false
42+
windows_nightly_main_enabled:
43+
type: boolean
44+
description: "Boolean to enable the Windows nightly main Swift version matrix job. Defaults to true."
45+
default: false
46+
3447
jobs:
3548
benchmarks:
3649
name: Benchmarks
@@ -44,3 +57,6 @@ jobs:
4457
matrix_linux_6_0_enabled: ${{ inputs.linux_6_0_enabled }}
4558
matrix_linux_nightly_6_0_enabled: ${{ inputs.linux_nightly_6_0_enabled }}
4659
matrix_linux_nightly_main_enabled: ${{ inputs.linux_nightly_main_enabled }}
60+
matrix_windows_6_0_enabled: ${{ inputs.windows_6_0_enabled }}
61+
matrix_windows_nightly_6_0_enabled: ${{ inputs.windows_nightly_6_0_enabled }}
62+
matrix_windows_nightly_main_enabled: ${{ inputs.windows_nightly_main_enabled }}

.github/workflows/cxx_interop.yml

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,19 @@ on:
2424
description: "Boolean to enable the Linux nightly main Swift version matrix job. Defaults to true."
2525
default: true
2626

27+
windows_6_0_enabled:
28+
type: boolean
29+
description: "Boolean to enable the Windows 6.0 Swift version matrix job. Defaults to true."
30+
default: false
31+
windows_nightly_6_0_enabled:
32+
type: boolean
33+
description: "Boolean to enable the Windows nightly 6.0 Swift version matrix job. Defaults to true."
34+
default: false
35+
windows_nightly_main_enabled:
36+
type: boolean
37+
description: "Boolean to enable the Windows nightly main Swift version matrix job. Defaults to true."
38+
default: false
39+
2740
jobs:
2841
cxx-interop:
2942
name: Cxx interop
@@ -37,3 +50,6 @@ jobs:
3750
matrix_linux_6_0_enabled: ${{ inputs.linux_6_0_enabled }}
3851
matrix_linux_nightly_6_0_enabled: ${{ inputs.linux_nightly_6_0_enabled }}
3952
matrix_linux_nightly_main_enabled: ${{ inputs.linux_nightly_main_enabled }}
53+
matrix_windows_6_0_enabled: ${{ inputs.windows_6_0_enabled }}
54+
matrix_windows_nightly_6_0_enabled: ${{ inputs.windows_nightly_6_0_enabled }}
55+
matrix_windows_nightly_main_enabled: ${{ inputs.windows_nightly_main_enabled }}

.github/workflows/swift_matrix.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ jobs:
149149
curl -s https://raw.githubusercontent.com/apple/swift-nio/main/scripts/check-matrix-job.sh | bash
150150
151151
windows:
152-
name: Windows (${{ matrix.swift.swift_version }})
152+
name: Windows (6.0)
153153
runs-on: windows-2022
154154
strategy:
155155
fail-fast: false
@@ -191,7 +191,7 @@ jobs:
191191
- image: swiftlang/swift:nightly-main-windowsservercore-1809
192192
swift_version: "nightly-main"
193193
enabled: ${{ inputs.matrix_windows_nightly_main_enabled }}
194-
if: ${{ inputs.matrix_windows_nightly_6_0_enabled }} || ${{ inputs.matrix_windows_nightly_main_enabled }}
194+
if: (${{ inputs.matrix_windows_nightly_6_0_enabled }} || ${{ inputs.matrix_windows_nightly_main_enabled }})
195195
steps:
196196
- name: Pull Docker image
197197
if: ${{ matrix.swift.enabled }}

0 commit comments

Comments
 (0)