-
Notifications
You must be signed in to change notification settings - Fork 191
feat: Set mode modeless for sendVerificationEmailModal to allow clickthrough overlay for password managers #2479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…-through overlay for password managers
This PR was not deployed automatically as @HarshMN2345 does not have access to the Railway project. In order to get automatic PR deploys, please add @HarshMN2345 to your workspace on Railway. |
WalkthroughThis pull request updates two package.json dependencies—@appwrite.io/pink-icons-svelte and @appwrite.io/pink-svelte—from build hash 8f82877 to 10305c4. It adds an exported boolean prop Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (3)
package.json
(1 hunks)src/lib/components/account/sendVerificationEmailModal.svelte
(1 hunks)src/lib/components/modal.svelte
(2 hunks)
🔇 Additional comments (4)
src/lib/components/modal.svelte (1)
33-33
: LGTM: Prop correctly forwarded.The
mode
prop is properly forwarded to the underlying Modal component using Svelte's shorthand syntax.src/lib/components/account/sendVerificationEmailModal.svelte (2)
138-139
: Verify modeless mode works with custom scrim overlay.Setting
mode="modeless"
allows click-through on the modal itself, but the custom.email-verification-scrim
overlay (lines 177-188) might still block interactions with password managers beneath it.Test that password managers can be accessed through the overlay when this modal is displayed. If clicks are still blocked, consider adding
pointer-events: none;
to.email-verification-scrim
andpointer-events: auto;
to the modal content.
177-188
: Potential conflict: Custom scrim may block click-through.The custom scrim overlay with
backdrop-filter
andbackground-color
might prevent the intended click-through behavior for password managers, even withmode="modeless"
.Verify that the scrim allows interactions with underlying elements (like password managers) when the modal is modeless. If not, you may need to adjust the CSS:
.email-verification-scrim { position: fixed; top: 0; left: 0; width: 100%; height: 100%; background-color: hsl(240 5% 8% / 0.6); backdrop-filter: blur(4px); display: flex; align-items: center; justify-content: center; + pointer-events: none; /* Allow click-through for modeless behavior */ } +/* Restore pointer events on modal content */ +.email-verification-scrim :global(dialog) { + pointer-events: auto; +}package.json (1)
27-29
: Request commit link for Modalmode
prop support
I couldn’t find any changelog or release notes for b93a4a4. Please share the GitHub repo/commit URL or changelog snippet where the Modal component’smode
prop was added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (3)
package.json
(1 hunks)src/lib/components/account/sendVerificationEmailModal.svelte
(1 hunks)src/lib/components/modal.svelte
(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- src/lib/components/account/sendVerificationEmailModal.svelte
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (2)
src/lib/components/modal.svelte (2)
17-17
: Well-defined prop with sensible default.The
modeless
boolean prop is properly typed and defaults tofalse
, maintaining backward compatibility with existing usages.
33-33
: Prop forwarding looks correct.The
modeless
prop is correctly forwarded to the inner Modal component using Svelte's shorthand syntax. Ensure this is tested with a password manager to confirm the click-through behavior works as intended for the use case described in the PR objectives.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (3)
package.json
(1 hunks)src/lib/components/account/sendVerificationEmailModal.svelte
(1 hunks)src/lib/components/modal.svelte
(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- src/lib/components/account/sendVerificationEmailModal.svelte
- package.json
What does this PR do?
(Provide a description of what this PR does.)
Test Plan
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)
Summary by CodeRabbit
New Features
Chores