Skip to content

Commit 8617bde

Browse files
Merge pull request #1023 from ItzNotABug/fix-ping
Use base class on dart/flutter for `ping`
2 parents 9134e34 + 34efd16 commit 8617bde

File tree

6 files changed

+18
-34
lines changed

6 files changed

+18
-34
lines changed

templates/dart/lib/src/client_base.dart.twig

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,15 @@ abstract class ClientBase implements Client {
2121
ClientBase addHeader(String key, String value);
2222

2323
@override
24-
Future<String> ping();
24+
Future<String> ping() async {
25+
final String apiPath = '/ping';
26+
final response = await call(
27+
HttpMethod.get,
28+
path: apiPath,
29+
responseType: ResponseType.plain,
30+
);
31+
return response.data;
32+
}
2533

2634
@override
2735
Future<Response> call(

templates/dart/lib/src/client_browser.dart.twig

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -77,14 +77,6 @@ class ClientBrowser extends ClientBase with ClientMixin {
7777
return this;
7878
}
7979

80-
@override
81-
Future<String> ping() async {
82-
final String apiPath = '/ping';
83-
final response = await call(HttpMethod.get, path: apiPath, responseType: ResponseType.plain);
84-
85-
return response.data;
86-
}
87-
8880
@override
8981
Future<String?> webAuth(Uri url) async {
9082
final request = http.Request('GET', url);

templates/dart/lib/src/client_io.dart.twig

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -89,14 +89,6 @@ class ClientIO extends ClientBase with ClientMixin {
8989
return this;
9090
}
9191

92-
@override
93-
Future<String> ping() async {
94-
final String apiPath = '/ping';
95-
final response = await call(HttpMethod.get, path: apiPath, responseType: ResponseType.plain);
96-
97-
return response.data;
98-
}
99-
10092
@override
10193
Future<Response> chunkedUpload({
10294
required String path,

templates/flutter/lib/src/client_base.dart.twig

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,15 @@ abstract class ClientBase implements Client {
2424
ClientBase addHeader(String key, String value);
2525

2626
@override
27-
Future<String> ping();
27+
Future<String> ping() async {
28+
final String apiPath = '/ping';
29+
final response = await call(
30+
HttpMethod.get,
31+
path: apiPath,
32+
responseType: ResponseType.plain,
33+
);
34+
return response.data;
35+
}
2836

2937
@override
3038
Future<Response> call(

templates/flutter/lib/src/client_browser.dart.twig

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -98,14 +98,6 @@ class ClientBrowser extends ClientBase with ClientMixin {
9898
return this;
9999
}
100100

101-
@override
102-
Future<String> ping() async {
103-
final String apiPath = '/ping';
104-
final response = await call(HttpMethod.get, path: apiPath, responseType: ResponseType.plain);
105-
106-
return response.data;
107-
}
108-
109101
Future init() async {
110102
final cookieFallback = web.window.localStorage['cookieFallback'];
111103
if (cookieFallback != null) {

templates/flutter/lib/src/client_io.dart.twig

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -130,14 +130,6 @@ class ClientIO extends ClientBase with ClientMixin {
130130
return this;
131131
}
132132

133-
@override
134-
Future<String> ping() async {
135-
final String apiPath = '/ping';
136-
final response = await call(HttpMethod.get, path: apiPath, responseType: ResponseType.plain);
137-
138-
return response.data;
139-
}
140-
141133
Future init() async {
142134
if(_initProgress) return;
143135
_initProgress = true;

0 commit comments

Comments
 (0)