Skip to content

Commit aac8df6

Browse files
Merge pull request #1036 from sahilsekr42/feat-1035-removing-redundant-async/await-patterns
removed returning await pattern from node templates
2 parents df18067 + 10f9d3b commit aac8df6

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

templates/node/src/services/template.ts.twig

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export class {{ service.name | caseUcfirst }} {
3636
* @throws {{ '{' }}{{ spec.title | caseUcfirst}}Exception}
3737
* @returns {{ '{' }}{{ method | getReturn(spec) | raw }}{{ '}' }}
3838
*/
39-
async {{ method.name | caseCamel }}{{ method.responseModel | getGenerics(spec) | raw }}({% for parameter in method.parameters.all %}{{ parameter.name | caseCamel | escapeKeyword }}{% if not parameter.required or parameter.nullable %}?{% endif %}: {{ parameter | getPropertyType(method) | raw }}{% if not loop.last %}, {% endif %}{% endfor %}{% if 'multipart/form-data' in method.consumes %}, onProgress = (progress: UploadProgress) => {}{% endif %}): {{ method | getReturn(spec) | raw }} {
39+
{{ method.name | caseCamel }}{{ method.responseModel | getGenerics(spec) | raw }}({% for parameter in method.parameters.all %}{{ parameter.name | caseCamel | escapeKeyword }}{% if not parameter.required or parameter.nullable %}?{% endif %}: {{ parameter | getPropertyType(method) | raw }}{% if not loop.last %}, {% endif %}{% endfor %}{% if 'multipart/form-data' in method.consumes %}, onProgress = (progress: UploadProgress) => {}{% endif %}): {{ method | getReturn(spec) | raw }} {
4040
{%~ for parameter in method.parameters.all %}
4141
{%~ if parameter.required %}
4242
if (typeof {{ parameter.name | caseCamel | escapeKeyword }} === 'undefined') {
@@ -68,22 +68,22 @@ export class {{ service.name | caseUcfirst }} {
6868
}
6969

7070
{%~ if method.type == 'webAuth' %}
71-
return await this.client.redirect(
71+
return this.client.redirect(
7272
'{{ method.method | caseLower }}',
7373
uri,
7474
apiHeaders,
7575
payload
7676
);
7777
{%~ elseif 'multipart/form-data' in method.consumes %}
78-
return await this.client.chunkedUpload(
78+
return this.client.chunkedUpload(
7979
'{{ method.method | caseLower }}',
8080
uri,
8181
apiHeaders,
8282
payload,
8383
onProgress
8484
);
8585
{%~ else %}
86-
return await this.client.call(
86+
return this.client.call(
8787
'{{ method.method | caseLower }}',
8888
uri,
8989
apiHeaders,

templates/react-native/src/services/template.ts.twig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ export class {{ service.name | caseUcfirst }} extends Service {
9393
const size = {{ parameter.name | caseCamel | escapeKeyword }}.size;
9494

9595
if (size <= Service.CHUNK_SIZE) {
96-
return await this.client.call('{{ method.method | caseLower }}', uri, {
96+
return this.client.call('{{ method.method | caseLower }}', uri, {
9797
{% for parameter in method.parameters.header %}
9898
'{{ parameter.name | caseCamel | escapeKeyword }}': this.client.${{ parameter.name | caseCamel | escapeKeyword }},
9999
{% endfor %}
@@ -163,7 +163,7 @@ export class {{ service.name | caseUcfirst }} extends Service {
163163
{% endif %}
164164
{% endfor %}
165165
{% else %}
166-
return await this.client.call('{{ method.method | caseLower }}', uri, {
166+
return this.client.call('{{ method.method | caseLower }}', uri, {
167167
{% for parameter in method.parameters.header %}
168168
'{{ parameter.name | caseCamel | escapeKeyword }}': this.client.${{ parameter.name | caseCamel | escapeKeyword }},
169169
{% endfor %}

templates/web/src/services/template.ts.twig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,15 +90,15 @@ export class {{ service.name | caseUcfirst }} {
9090
{%~ elseif method.type == 'location' %}
9191
return uri.toString();
9292
{%~ elseif 'multipart/form-data' in method.consumes %}
93-
return await this.client.chunkedUpload(
93+
return this.client.chunkedUpload(
9494
'{{ method.method | caseLower }}',
9595
uri,
9696
apiHeaders,
9797
payload,
9898
onProgress
9999
);
100100
{%~ else %}
101-
return await this.client.call(
101+
return this.client.call(
102102
'{{ method.method | caseLower }}',
103103
uri,
104104
apiHeaders,

0 commit comments

Comments
 (0)