Skip to content

chore: remove unnecessary async and spacing #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 10, 2025
Merged

Conversation

ChiragAgg5k
Copy link
Member

@ChiragAgg5k ChiragAgg5k commented Mar 7, 2025

What does this PR do?

  1. fix spacing in sdk for web (there was one extra in front of method names).
  2. remove unnecessary async in sdk for node.
  3. make the return for webAuth be string or void instead of promise. this previously did not give an error since methods were async.
  4. remove unnecessary adding of payload in web auth. it would just add project in the payload, which would already be added in headers:
Screenshot 2025-03-07 at 2 10 23 PM

Test Plan

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

yes.

@ChiragAgg5k ChiragAgg5k requested a review from loks0n March 7, 2025 14:12
@christyjacob4 christyjacob4 merged commit 6a10a65 into master Mar 10, 2025
68 of 69 checks passed
@christyjacob4 christyjacob4 deleted the fix-async-calls branch March 10, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants