-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[qs] introduce BatchInfoExt enum to support extensible BatchInfo #18084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ibalajiarun
wants to merge
1
commit into
balaji/enc-pool-2
Choose a base branch
from
balaji/enc-pool-3
base: balaji/enc-pool-2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+342
−147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Nov 11, 2025
5c812a3 to
efcdf59
Compare
4e6435b to
e1a91cd
Compare
efcdf59 to
ec38b39
Compare
e1a91cd to
78bff66
Compare
78bff66 to
acffb95
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
acffb95 to
c07419d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
✅ Forge suite
|
Contributor
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CICD:run-e2e-tests
when this label is present github actions will run all land-blocking e2e tests from the PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Description
This PR introduces
BatchInfoExtenum that will replaceBatchInfo. This should allow easy addition of new fields toBatchInfo. Currently, there are two variants:V1which is same as BatchInfo andV2which includes extra fields to specifyBatchKind::{Normal, Encrypted}.Normalis a normal batch andEncryptedis a batch with encrypted transactions.When network message is received for
ProofOfStore<BatchInfo>, it's converted intoProofOfStore<BatchInfoExt>and processed internally. Similarly, forSignedBatchInfo. In this PR,BatchInfois converted intoBatchInfoExt::V1. When a network message is sent out, it's converted intoProofOfStore<BatchInfo>andSignedBatchInfo<BatchInfo>.Most internal message passing, except that deals with
Batchmessages, usesBatchInfoExtinstead ofBatchInfo.