Skip to content

Conversation

@ibalajiarun
Copy link
Contributor

@ibalajiarun ibalajiarun commented Nov 11, 2025

Description

This PR introduces BatchInfoExt enum that will replace BatchInfo. This should allow easy addition of new fields to BatchInfo. Currently, there are two variants: V1 which is same as BatchInfo and V2 which includes extra fields to specify BatchKind::{Normal, Encrypted}. Normal is a normal batch and Encrypted is a batch with encrypted transactions.

When network message is received for ProofOfStore<BatchInfo>, it's converted into ProofOfStore<BatchInfoExt> and processed internally. Similarly, for SignedBatchInfo. In this PR, BatchInfo is converted into BatchInfoExt::V1. When a network message is sent out, it's converted into ProofOfStore<BatchInfo> and SignedBatchInfo<BatchInfo>.

Most internal message passing, except that deals with Batch messages, uses BatchInfoExt instead of BatchInfo.

Copy link
Contributor Author

ibalajiarun commented Nov 11, 2025

@ibalajiarun ibalajiarun force-pushed the balaji/enc-pool-2 branch 2 times, most recently from 5c812a3 to efcdf59 Compare November 11, 2025 20:49
@ibalajiarun ibalajiarun changed the base branch from balaji/enc-pool-2 to graphite-base/18084 November 11, 2025 21:08
@ibalajiarun ibalajiarun changed the base branch from graphite-base/18084 to balaji/enc-pool-2 November 11, 2025 21:37
@ibalajiarun ibalajiarun changed the title [qs] introduce BatchInfoExt for Proofs and Signed infos [qs] introduce BatchInfoExt enum to support extensible BatchInfo Nov 11, 2025
@ibalajiarun ibalajiarun marked this pull request as ready for review November 11, 2025 22:22
@ibalajiarun ibalajiarun added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Nov 11, 2025
@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment has been minimized.

@github-actions

This comment was marked as resolved.

@ibalajiarun ibalajiarun marked this pull request as draft November 11, 2025 22:59
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite compat success on c6ae38ec4156111b3c14951f8665cdb3ec87b984 ==> c07419d7552b9079ea54c4c27d3c52aefb4ed56c

Compatibility test results for c6ae38ec4156111b3c14951f8665cdb3ec87b984 ==> c07419d7552b9079ea54c4c27d3c52aefb4ed56c (PR)
1. Check liveness of validators at old version: c6ae38ec4156111b3c14951f8665cdb3ec87b984
compatibility::simple-validator-upgrade::liveness-check : committed: 13005.60 txn/s, latency: 2629.19 ms, (p50: 2700 ms, p70: 3000, p90: 3200 ms, p99: 3500 ms), latency samples: 429560
2. Upgrading first Validator to new version: c07419d7552b9079ea54c4c27d3c52aefb4ed56c
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4306.92 txn/s, latency: 7863.59 ms, (p50: 8900 ms, p70: 9000, p90: 9000 ms, p99: 9100 ms), latency samples: 153720
3. Upgrading rest of first batch to new version: c07419d7552b9079ea54c4c27d3c52aefb4ed56c
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4279.67 txn/s, latency: 7901.98 ms, (p50: 8900 ms, p70: 9100, p90: 9200 ms, p99: 9300 ms), latency samples: 151460
4. upgrading second batch to new version: c07419d7552b9079ea54c4c27d3c52aefb4ed56c
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 7568.20 txn/s, latency: 4489.15 ms, (p50: 4900 ms, p70: 5000, p90: 5100 ms, p99: 5200 ms), latency samples: 253860
5. check swarm health
Compatibility test for c6ae38ec4156111b3c14951f8665cdb3ec87b984 ==> c07419d7552b9079ea54c4c27d3c52aefb4ed56c passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on c07419d7552b9079ea54c4c27d3c52aefb4ed56c

two traffics test: inner traffic : committed: 13837.99 txn/s, submitted: 13838.10 txn/s, expired: 0.11 txn/s, latency: 2717.65 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 4500 ms), latency samples: 5148320
two traffics test : committed: 100.03 txn/s, latency: 859.46 ms, (p50: 800 ms, p70: 900, p90: 1000 ms, p99: 1700 ms), latency samples: 1680
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.293, avg: 2.075", "ConsensusProposalToOrdered: max: 0.174, avg: 0.171", "ConsensusOrderedToCommit: max: 0.163, avg: 0.113", "ConsensusProposalToCommit: max: 0.335, avg: 0.284"]
Max non-epoch-change gap was: 1 rounds at version 229300 (avg 0.00) [limit 4], 1.19s no progress at version 233278 (avg 0.07s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.52s no progress at version 1986325 (avg 0.52s) [limit 16].
Test Ok

@ibalajiarun ibalajiarun marked this pull request as ready for review November 12, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants