Skip to content

Commit 5ee1e35

Browse files
authored
Update Selenium to 4.33.0 +semver:feature (#101)
* Update Selenium to 4.33.0 +semver:feature * fix setting of implicit wait
1 parent fe48a91 commit 5ee1e35

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@
121121
<dependency>
122122
<groupId>com.google.guava</groupId>
123123
<artifactId>guava</artifactId>
124-
<version>33.4.0-jre</version>
124+
<version>33.4.8-jre</version>
125125
</dependency>
126126
<dependency>
127127
<groupId>com.fasterxml.jackson.core</groupId>
@@ -131,7 +131,7 @@
131131
<dependency>
132132
<groupId>org.seleniumhq.selenium</groupId>
133133
<artifactId>selenium-java</artifactId>
134-
<version>4.28.1</version>
134+
<version>4.33.0</version>
135135
</dependency>
136136
<dependency>
137137
<groupId>io.appium</groupId>

src/test/java/tests/applications/windowsApp/WindowsApplication.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
import java.net.URL;
99
import java.time.Duration;
10-
import java.util.concurrent.TimeUnit;
1110

1211
public class WindowsApplication implements IApplication {
1312
private long implicitWaitSeconds;
@@ -34,7 +33,7 @@ public boolean isStarted() {
3433
public void setImplicitWaitTimeout(Duration value) {
3534
long valueInSeconds = value.getSeconds();
3635
if (implicitWaitSeconds != valueInSeconds){
37-
driver.manage().timeouts().implicitlyWait(value.toMillis(), TimeUnit.MILLISECONDS);
36+
driver.manage().timeouts().implicitlyWait(value);
3837
implicitWaitSeconds = valueInSeconds;
3938
}
4039
}

0 commit comments

Comments
 (0)