Add melody function to play sequences of tones#587
Add melody function to play sequences of tones#587toaha63 wants to merge 1 commit intoarduino:masterfrom
melody function to play sequences of tones#587Conversation
Added a new function named melody() so that user can play melody tone by passing pin number,an array of notes and an array of duration in ms
|
Memory usage change @ 3febd09
Click for full report table
Click for full report CSV |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
hi @per1234 |
|
My role in this repository is janitorial. I provide support to the contributors as needed and keep the place tidy. I am not in a role to decide on significant changes to the codebase such as you have proposed here. Something important to understand is that the goal is for every Arduino boards platform to implement a standardized API, as described by the Arduino Language Reference: https://docs.arduino.cc/language-reference/ The standardization is important for the sake of portability. If all cores implement a standardized API, then sketches and libraries that only use that API will work with every one of the diverse array of boards in the Arduino hardware ecosystem. Conversely, if we only implement a capability one core, then users will find that code utilizing that capability won't compile for boards of any other platform. In order to facilitate standardization of core APIs, Arduino has created a reusable codebase that contains all the non-architecture specific core code: https://github.com/arduino/ArduinoCore-API You are proposing an expansion of the standardized core API. It is true that, if accepted, this should be implemented in the "Arduino AVR Boards" core, but the same should also be done in the core of every other platform. For this reason, it is best to start by proposing the addition of the new capability in the |
melody function to play sequences of tones
Added a new function named melody() so that user can play melody tone by passing pin number,an array of notes and an array of duration in ms