Skip to content

Commit 4bae9be

Browse files
committed
Fix issue with merging Helm values in marshalParamsOverride function
Signed-off-by: Aleksandr Petrov <burnb83@gmail.com>
1 parent a2eaa1c commit 4bae9be

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

pkg/argocd/update.go

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -418,6 +418,7 @@ func marshalParamsOverride(app *v1alpha1.Application, originalData []byte) ([]by
418418
if strings.HasPrefix(app.Annotations[common.WriteBackTargetAnnotation], common.HelmPrefix) {
419419
images := GetImagesFromApplication(app)
420420

421+
var helmValues string
421422
for _, c := range images {
422423
image := c.ImageAlias
423424
if image == "" {
@@ -442,16 +443,16 @@ func marshalParamsOverride(app *v1alpha1.Application, originalData []byte) ([]by
442443
}
443444

444445
// Build string with YAML format to merge with originalData values
445-
helmValues := fmt.Sprintf("%s: %s\n%s: %s", helmAnnotationParamName, helmParamName.Value, helmAnnotationParamVersion, helmParamVersion.Value)
446-
447-
var mergedParams *conflate.Conflate
448-
mergedParams, err = conflate.FromData(originalData, []byte(helmValues))
449-
if err != nil {
450-
return nil, err
451-
}
446+
helmValues += fmt.Sprintf("%s: %s\n%s: %s\n", helmAnnotationParamName, helmParamName.Value, helmAnnotationParamVersion, helmParamVersion.Value)
447+
}
452448

453-
override, err = mergedParams.MarshalYAML()
449+
var mergedParams *conflate.Conflate
450+
mergedParams, err = conflate.FromData(originalData, []byte(helmValues))
451+
if err != nil {
452+
return nil, err
454453
}
454+
455+
override, err = mergedParams.MarshalYAML()
455456
} else {
456457
var params helmOverride
457458
newParams := helmOverride{

0 commit comments

Comments
 (0)