Skip to content

Commit 89a261e

Browse files
chengfangjannfis
andauthored
fix: missing namespace on clusterrolebinding in install manifests (#860)
Signed-off-by: Cheng Fang <cfang@redhat.com> Co-authored-by: Jann Fischer <jann@mistrust.net>
1 parent 60b89f2 commit 89a261e

File tree

3 files changed

+10
-0
lines changed

3 files changed

+10
-0
lines changed

docs/install/installation.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@ Argo CD is running. Don't worry, without any configuration, it will not start me
2828
kubectl apply -n argocd -f https://raw.githubusercontent.com/argoproj-labs/argocd-image-updater/stable/manifests/install.yaml
2929
```
3030

31+
!!! warning
32+
The installation manifests include `ClusterRoleBinding` resources that reference `argocd` namespace. If you are installing Argo CD into a different
33+
namespace then make sure to update the namespace reference.
34+
3135
!!!note "A word on high availability"
3236
It is not advised to run multiple replicas of the same Argo CD Image Updater
3337
instance. Just leave the number of replicas at 1, otherwise weird side
@@ -70,6 +74,10 @@ kubectl create namespace argocd-image-updater
7074
kubectl apply -n argocd-image-updater -f https://raw.githubusercontent.com/argoproj-labs/argocd-image-updater/stable/manifests/install.yaml
7175
```
7276

77+
!!! warning
78+
The installation manifests include `ClusterRoleBinding` resources that reference `argocd` namespace. If you are installing Argo CD into a different
79+
namespace then make sure to update the namespace reference.
80+
7381
!!!note "A word on high availability"
7482
It is not advised to run multiple replicas of the same Argo CD Image Updater
7583
instance. Just leave the number of replicas at 1, otherwise weird side

manifests/base/rbac/argocd-image-updater-clusterrolebinding.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,3 +13,4 @@ roleRef:
1313
subjects:
1414
- kind: ServiceAccount
1515
name: argocd-image-updater
16+
namespace: argocd

manifests/install.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ roleRef:
8282
subjects:
8383
- kind: ServiceAccount
8484
name: argocd-image-updater
85+
namespace: argocd
8586
---
8687
apiVersion: v1
8788
kind: ConfigMap

0 commit comments

Comments
 (0)