fix: crash due to store is nil (#723)

pasha-codefresh · web-flow · commit eb1d8d30bb22 · 2024-05-27T11:41:14.000-04:00
Signed-off-by: Pasha Kostohrys &lt;pavel@codefresh.io&gt;
diff --git a/pkg/argocd/gitcreds.go b/pkg/argocd/gitcreds.go
@@ -8,6 +8,7 @@ import (
 
 	"github.com/argoproj/argo-cd/v2/pkg/apis/application/v1alpha1"
 	"github.com/argoproj/argo-cd/v2/util/db"
+	argoGit "github.com/argoproj/argo-cd/v2/util/git"
 	"github.com/argoproj/argo-cd/v2/util/settings"
 
 	"github.com/argoproj-labs/argocd-image-updater/ext/git"
@@ -43,7 +44,7 @@ func getCredsFromArgoCD(wbc *WriteBackConfig, kubeClient *kube.KubernetesClient)
 	if !repo.HasCredentials() {
 		return nil, fmt.Errorf("credentials for '%s' are not configured in Argo CD settings", wbc.GitRepo)
 	}
-	return repo.GetGitCreds(nil), nil
+	return repo.GetGitCreds(argoGit.NoopCredsStore{}), nil
 }
 
 // getCredsFromSecret loads repository credentials from secret

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@ import (`
`8`	`8`
`9`	`9`	`"github.com/argoproj/argo-cd/v2/pkg/apis/application/v1alpha1"`
`10`	`10`	`"github.com/argoproj/argo-cd/v2/util/db"`
	`11`	`+ argoGit "github.com/argoproj/argo-cd/v2/util/git"`
`11`	`12`	`"github.com/argoproj/argo-cd/v2/util/settings"`
`12`	`13`
`13`	`14`	`"github.com/argoproj-labs/argocd-image-updater/ext/git"`
`@@ -43,7 +44,7 @@ func getCredsFromArgoCD(wbc WriteBackConfig, kubeClient kube.KubernetesClient)`
`43`	`44`	`if !repo.HasCredentials() {`
`44`	`45`	`return nil, fmt.Errorf("credentials for '%s' are not configured in Argo CD settings", wbc.GitRepo)`
`45`	`46`	`}`
`46`		`- return repo.GetGitCreds(nil), nil`
	`47`	`+ return repo.GetGitCreds(argoGit.NoopCredsStore{}), nil`
`47`	`48`	`}`
`48`	`49`
`49`	`50`	`// getCredsFromSecret loads repository credentials from secret`