Preserve formatting in Helm values files #1166
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamalama
requested review from
jannfis,
chengfang,
pasha-codefresh and
ishitasequeira
as code owners
Signed-off-by: Graham Beckley <gbeckley@mozilla.com>
Signed-off-by: Graham Beckley <gbeckley@mozilla.com>
Signed-off-by: Graham Beckley <gbeckley@mozilla.com>
Signed-off-by: Graham Beckley <gbeckley@mozilla.com>
Signed-off-by: Graham Beckley <gbeckley@mozilla.com>
Signed-off-by: Graham Beckley <gbeckley@mozilla.com>
Signed-off-by: Graham Beckley <gbeckley@mozilla.com>
grahamalama
force-pushed
the
edit-helm-yaml-formatting
branch
from
9438961 to
d67d921
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1166 +/- ##
==========================================
- Coverage 63.34% 62.81% -0.53%
==========================================
Files 15 15
Lines 2357 2364 +7
==========================================
- Hits 1493 1485 -8
- Misses 769 780 +11
- Partials 95 99 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Graham Beckley <gbeckley@mozilla.com>
Signed-off-by: Graham Beckley <gbeckley@mozilla.com>
|
Thanks for the contribution, @grahamalama. PRs #1055 and #1062, based on #1039, were merged and included in v0.16.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welp, I spent quite some time writing this PR to preserve formatting in Helm values files only to discover that there already some activity in this area, namely #1039 and this branch referenced in that PR.
You can consider this another implementation and maybe decide between the two approaches. There's still more polish I could add, but since I discovered #1039, I thought I'd get this PR up to see if I should keep working on it.
Whether this PR or #1039, it'd be nice to get this general feature of preserving the formatting of Helm values files in.