Lsp tooling upgrade experiment #1108
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed unused variable warnings in tooling_api.rs - Added missing LazySpan import to fix compilation - Updated test snapshots to consistent (line, column) format - All tests now passing: 81 in hir-analysis, 8 in language-server 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Added visit_expr method to PositionCollector to handle method calls and field access - Method calls like container.get() are being detected (positions created) but resolution returns empty paths - Complex method calls like self.inner.foo() are not being detected at all - Need to debug why probe_method_for_language_server is failing for simple cases - Need to investigate why method calls on complex receiver expressions aren't detected 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Made LocalBinding and ExprProp.binding field public in ty_check::env - Re-exported LocalBinding from ty_check module - Removed duplicate PublicLocalBinding enum and used real LocalBinding throughout - Added helper function get_local_binding_definition_span for goto functionality - Cleaned up analyze_function_for_language_server to use real binding data This provides much better integration with the existing type checking machinery. Method call resolution issue still remains - positions detected but resolution failing. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please ignore this experiment
don't merge this it was only for science