First version of string literals handling #176
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-xo
reviewed
Sep 3, 2025
| , SFunction <$> (pKeyword "function" *> identifier) <*> (parens (commaSep coreArg)) <*> (symbol "->" *> coreType) | ||
| <*> (symbol "{" *> many coreStmt <* symbol "}") | ||
| , SAssembly <$> (pKeyword "assembly" *> yulBlock) | ||
| , SRevert <$> (pKeyword "revert" *> stringLiteral) |
There was a problem hiding this comment.
Don't know if we need revert builtin in core, but I renamed it to __revert__, because otherwise you cannot define a function called revert
| Just e -> pure (e, []) | ||
| Nothing -> pure (Core.EVar (unwrapId x), []) | ||
| -- special handling of revert | ||
| emitExp (Call _ (Id "revert" _) [Lit(StrLit s)]) = pure(Core.EUnit, [Core.SRevert s]) |
There was a problem hiding this comment.
Is this supposed to be commented?
There was a problem hiding this comment.
Yes, I have disabled special handling of revert.
Another option might be to keep special handling of revert and transform string literals on the Core <-> Yul stage.
But the current typechecker chokes on type literals, so I decided to do it in the preliminar desugaring stage, at least for now.
|
For comnparison, I will try another approach, keeping string literals throughout the frontend and desugaring them in the backend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick and dirty string literal handling - literals longer than 32 chars are truncated