Skip to content

Commit 35dae2a

Browse files
authored
Merge pull request #23 from armingh2000/fix/fact_scorer_prompt
fix: incorrect fact scorer prompt
2 parents 49748e6 + 9cf65e7 commit 35dae2a

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,10 @@ All notable changes to this project will be documented in this file.
7676
- Add fact scorer demons json file
7777
- Add CONTRIBUTING.md guidelines
7878

79+
## v 1.2.0 - 2024-04-19
80+
81+
- Fix knowledge source in fact scorer prompt (used to send all knowledge sources in one prompt)
82+
7983
<!--
8084
### Added
8185

FactScoreLite/factscore.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,16 +98,18 @@ def get_decisions(
9898
decisions = self.decisions_handler.load()
9999
scores = []
100100
init_scores = []
101+
cur_knw_idx = 0
101102

102-
for enrty in decisions:
103-
score, init_score = self.calculate_score(enrty["decision"])
103+
for entry in decisions:
104+
score, init_score = self.calculate_score(entry["decision"])
104105
init_scores.append(init_score)
105106
scores.append(score)
107+
cur_knw_idx += 1
106108

107109
for entry in tqdm(generation_facts_pairs[len(decisions) :]):
108110
generation, facts = entry["generation"], entry["facts"]
109111

110-
decision = self.fact_scorer.get_score(facts, knowledge_sources)
112+
decision = self.fact_scorer.get_score(facts, knowledge_sources[cur_knw_idx])
111113
score, init_score = self.calculate_score(decision)
112114

113115
init_scores.append(init_score)

setup.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[metadata]
22
name = FactScoreLite
3-
version = 1.1.0
3+
version = 1.2.0
44
author = armingh2000
55
author_email =
66
license = MIT

0 commit comments

Comments
 (0)